Fix sound effects in Koei games by adding missing MMC5 features #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sound effects in JP Koei games
This was referenced Aug 29, 2025
|
Missing sound effects in Koei games is Sourceforge bug 797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the length counters and envelopes for the MMC5 pulse channels, fixing missing sound effects in the Japanese versions of various Koei games. It also halves the volume of the MMC5 pulse channels to bring them in line with the APU channels.
I've hooked up the 240Hz "frame" sequencer via
MapIRQHook, which makes me vaguely queasy since it has nothing to do with IRQs, but I don't see a better way of doing it, and it matches how the corresponding sequencer in the NES APU is hooked up (MapIRQHookandFCEU_SoundCPUHookare called from the same place in the CPU loop, with the same argument).This patch probably breaks compatibility with existing savestates and movies for MMC5 games since it adds a whole bunch of saved state variables to the mapper (and deletes one).