Skip to content

fix(ci): add always() to publish_legacy_aiox_core so scoped packages=aiox-core dispatches actually run #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pedrovaleriolopez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): add always() to publish_legacy_aiox_core so scoped packages=aiox-core dispatches actually run #828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,8 +397,21 @@ jobs:
# in parallel, the legacy smoke test races against npm propagation of the
# scoped package and times out — making the workflow appear failed even
# though both packages were published successfully.
#
# `needs.publish.result == 'skipped'` is an intentionally allowed case
# (a scoped `packages=aiox-core` dispatch, without `core`, skips `publish`
# by design). GitHub Actions propagates a skipped `needs` job to this job
# by default REGARDLESS of a custom `if:` — the only way to opt out of
# that default propagation is to start the expression with `always()`.
# Without it, this whole condition was dead code: a scoped
# `packages=aiox-core` dispatch could never actually run this job. See
# https://github.com/SynkraAI/aiox-core/issues/827 (Bug 3).
#
# `always()` also bypasses the *failure*-propagation default, so the
# `test`/`build` success checks below are load-bearing, not redundant —
# without them this job would run even when `test` or `build` failed.
needs: [test, build, publish]
if: ${{ contains(format(',{0},', needs.build.outputs.packages), ',aiox-core,') && (needs.publish.result == 'success' || needs.publish.result == 'skipped') }}
if: ${{ always() && needs.test.result == 'success' && needs.build.result == 'success' && contains(format(',{0},', needs.build.outputs.packages), ',aiox-core,') && (needs.publish.result == 'success' || needs.publish.result == 'skipped') }}
runs-on: ubuntu-latest
outputs:
published: ${{ steps.should-publish.outputs.should_publish }}
Expand Down