fix(ci): add always() to publish_legacy_aiox_core so scoped packages=aiox-core dispatches actually run - #828
Conversation
…aiox-core dispatches actually run Bug 3 from issue #827: publish_legacy_aiox_core's `if:` explicitly tries to allow `needs.publish.result == 'skipped'` (the expected state when a scoped `packages=aiox-core` dispatch, without `core`, causes `publish`'s own `if:` to evaluate false). But GitHub Actions propagates a skipped `needs` job to dependents by default, REGARDLESS of a custom `if:` expression — the only way to opt out is to start the expression with `always()`. Without it, the "skipped is OK" branch of the condition was dead code: a scoped `packages=aiox-core`-only dispatch could never actually run this job, verified live in runs #31897480528 and #31898069540 (both show `publish_legacy_aiox_core: skipped`). Adding `always()` also removes the *implicit* failure-propagation default for every `needs` entry, not just `publish` — so the explicit `needs.test.result == 'success' && needs.build.result == 'success'` checks are load-bearing here, not decorative. Without them this job would now run even when `test` or `build` failed. No behavior change intended for the `packages=all` / `packages=core` paths already exercised in production (run #31898409032, which correctly ran `publish_legacy_aiox_core` and published `aiox-core` because `publish` itself was NOT skipped there) — this only changes what happens for the previously-dead `packages=aiox-core`-only input. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
area: docs
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 42 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
📊 Coverage ReportCoverage report not available
Generated by PR Automation (Story 6.1) |
1 participant
Why
Bug 3 from #827:
publish_legacy_aiox_core'sif:explicitly tries to allowneeds.publish.result == 'skipped'(the expected state when a scopedpackages=aiox-coredispatch, withoutcore, causespublish's ownif:to evaluate false). But GitHub Actions propagates a skippedneedsjob to dependents by default, regardless of a customif:expression — the only way to opt out is to start the expression withalways(). Without it, the "skipped is OK" branch of the condition was dead code: a scopedpackages=aiox-core-only dispatch could never actually run this job.Verified live in two separate runs:
#31897480528and#31898069540— bothpackages=aiox-core-only dispatches, both showpublish_legacy_aiox_core: skipped.What
always()also removes the implicit failure-propagation default for everyneedsentry, not justpublish— so the addedneeds.test.result == 'success' && needs.build.result == 'success'checks are load-bearing, not decorative. Without them this job would now run even whentestorbuildfailed.Blast radius
No behavior change intended for the
packages=all/packages=corepaths already exercised in production (#31898409032, which correctly ranpublish_legacy_aiox_coreand publishedaiox-core@5.4.0becausepublishitself was not skipped there) — this only changes what happens for the previously-deadpackages=aiox-core-only input.Not in scope
Sibling jobs in this workflow (e.g.
smoke_test_exports) may share the same class of skip-propagation gap — not audited/fixed here, flagged in #827 for a separate pass.Not urgent — no
--admin, waiting for full green CI before merge, per team decision after today's release incident.🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 5 noreply@anthropic.com