Skip to content

Fix: Check if method implements any interface method from the codeunit's interface or interfaces it extends #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rvanbekkum wants to merge 4 commits into
base: prerelease
Choose a base branch
from
Open

Fix: Check if method implements any interface method from the codeunit's interface or interfaces it extends #1202

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f51e14c
Fix: Check if method implements any interface method from the codeuni…
Dec 9, 2025
996ceee
Add using directive
Dec 9, 2025
2a80ef8
Revert change method signature
Dec 9, 2025
d6f02fe
Add directive (runtime 14.0)
Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion BusinessCentral.LinterCop/Helpers/HelperFunctions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using Microsoft.Dynamics.Nav.CodeAnalysis;
using Microsoft.Dynamics.Nav.CodeAnalysis.Diagnostics;
using Microsoft.Dynamics.Nav.CodeAnalysis.Symbols;
using Microsoft.Dynamics.Nav.CodeAnalysis.Syntax;
using System.Text.RegularExpressions;
using Microsoft.Dynamics.Nav.CodeAnalysis.Text;
Expand All @@ -22,7 +23,7 @@ public static bool MethodImplementsInterfaceMethod(IApplicationObjectTypeSymbol?

foreach (var implementedInterface in codeunitSymbol.ImplementedInterfaces)
{
if (implementedInterface.GetMembers().OfType<IMethodSymbol>().Any(interfaceMethodSymbol => MethodImplementsInterfaceMethod(methodSymbol, interfaceMethodSymbol)))
if (MethodImplementsInterfaceMethod(implementedInterface, methodSymbol))
{
return true;
}
Expand All @@ -31,6 +32,25 @@ public static bool MethodImplementsInterfaceMethod(IApplicationObjectTypeSymbol?
return false;
}

public static bool MethodImplementsInterfaceMethod(IInterfaceTypeSymbol interfaceTypeSymbol, IMethodSymbol methodSymbol)
{
if (interfaceTypeSymbol.GetMembers().OfType<IMethodSymbol>().Any(interfaceMethodSymbol => MethodImplementsInterfaceMethod(methodSymbol, interfaceMethodSymbol)))
{
return true;
}
#if !LessThenFall2024
foreach (var extendedInterface in interfaceTypeSymbol.ExtendedInterfaces)
{
if (MethodImplementsInterfaceMethod(extendedInterface, methodSymbol))
{
return true;
}
}
#endif

return false;
}

public static bool MethodImplementsInterfaceMethod(IMethodSymbol methodSymbol, IMethodSymbol interfaceMethodSymbol)
{
if (methodSymbol.Name != interfaceMethodSymbol.Name)
Expand Down