Fix: Check if method implements any interface method from the codeunit's interface or interfaces it extends#1202
Open
rvanbekkum wants to merge 4 commits intoStefanMaron:prereleasefrom
Conversation
added 4 commits
December 9, 2025 09:29
…t's interface or interfaces it extends
Collaborator
|
Hi @rvanbekkum , thank you for providing this fix for the false positieve. Would it be possible to include automated test(s) in the PR for these scenarios? |
Contributor
Author
|
False positive from LC0052 would be raised with this example: interface IBase
{
procedure SomeBaseInterfaceProcedure();
}
interface IExtended extends IBase
{
procedure SomeExtendedInterfaceProcedure();
}
codeunit 51010 ExtendedImpl implements IExtended
{
Access = Internal;
procedure SomeBaseInterfaceProcedure()
begin
Message('Hello Base');
end;
procedure SomeExtendedInterfaceProcedure() // This would raise a false positive from LC0052, but this has been fixed.
begin
Message('Hello Extended');
end;
}would something of that form be a good test to ensure this false positive does not occur? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Check if method implements any interface method from the codeunit's interface or interfaces it extends.
The method did not account for
ISomeInterface extends ISomeBaseInterface, because that wasn't available with older runtimes.This fixes false positives from LC0052 and LC0053 which check for unused internal procedures.