Popup images wikipedia style #986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images are still broken for me so can't evaluate properly |
My bad @bryceerobertson , should be fixed now, at least in production. If you are having issues in dev, you can clear cache in http://localhost:8787/cache |
|
I'm having problems with my Cursor which I don't have time to fix at the moment so I suggest pushing to prod and we can test there |
bryceerobertson
previously approved these changes
Aug 26, 2025
|
I investigated Wikipedia's code, and they feed the dimensions of the image in the metadata at the same time the glossary info is fed. Updated this in StampyAI/GDocsRelatedThings#101, we should merge both together. |
LeMurphant
force-pushed
the
murphant-popup-images-wikipedia-style
branch
from
efbfbf3 to
28bd336
Compare
bryceerobertson
previously approved these changes
Sep 27, 2025
Aprillion
reviewed
Oct 4, 2025
History was rewritten to sidestep a merge conflict
LeMurphant
force-pushed
the
murphant-popup-images-wikipedia-style
branch
from
11f8151 to
0abbc72
Compare
|
I had to rewrite git history to sidestep merge issues. Now working on fixing issues that were raised. |
Aprillion
approved these changes
Nov 3, 2025
This was referenced Nov 3, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate to #976
Follow guidelines in #976 (comment)
Closer to original style
It would be cleaner to have the layout calculated with columns/rows, but I never got it to work properly.