Skip to content

Conversation

@LeMurphant
Copy link
Collaborator

@LeMurphant LeMurphant commented Aug 12, 2025

Fix #768, but also adds different features.

For large screens (~1500px wide), move glossary/footnotes popup to the right. This allows a bunch of nice options, like uncropped images.

Also changed logic for showing/hiding popups to reduce popup lag and shrank popup padding. Images are not a good indicator, I suggest trying it out.
image
image
image
Reducing width of window
image
image

90% vibe coded to get a feel for it. If we are happy with the result, I will go over the code more closely.

@LeMurphant LeMurphant force-pushed the murphant-image-improvements branch from 3484458 to 92e9b5d Compare August 12, 2025 17:06
@LeMurphant
Copy link
Collaborator Author

I notice there were previously some image popups on mobile which are now hidden. I think the interface is better when they are absent, open to dissenting opinions.

There is also an issue on mobile where glossary items on the right of the page don't appear.

@LeMurphant LeMurphant force-pushed the murphant-image-improvements branch from 92e9b5d to 748effd Compare August 12, 2025 17:59
@LeMurphant LeMurphant force-pushed the murphant-image-improvements branch from 748effd to f306684 Compare August 12, 2025 18:09
/public/build
/.mf
/.idea
.venv/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love this, but my linter kept giving me warnings for some time

@bryceerobertson
Copy link
Member

I don't like the image being outside the box. Since Melissa's design had them in the box I think it's best to keep that

@LeMurphant
Copy link
Collaborator Author

Based on discussion with Bryce

  • Keep original popup layout
  • Make text width fixed, a bit less than right now (keep height constant)
  • If there is an image, append this image to the right (extend the box)
  • Have the image match the vspace, expand the hspace (to a point)
  • Try to keep images square-ish
  • Also, have the popup be above if hover at bottom of page
  • Add a small delay before popup, half of what wikipedia does
  • Try the wikipedia solution of "wide image up top, tall image on right)

@LeMurphant
Copy link
Collaborator Author

Superceded by #986

@LeMurphant LeMurphant closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glossary image takes up too much space

3 participants