Skip to content

Conversation

marcintyminski
Copy link
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Copy link

github-actions bot commented Oct 6, 2025

Duplicate profile check: Passed - no duplicate profiles detected.

Copy link

github-actions bot commented Oct 6, 2025

Copy link

github-actions bot commented Oct 6, 2025

File Coverage
All files 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/aqara/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/frient/init.lua 86%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-smoke-detector/src/aqara-gas/init.lua 94%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 86d706b

Copy link

github-actions bot commented Oct 6, 2025

Test Results

   71 files    455 suites   0s ⏱️
2 354 tests 2 354 ✅ 0 💤 0 ❌
3 989 runs  3 989 ✅ 0 💤 0 ❌

Results for commit 86d706b.

if device:supports_capability(capabilities.smokeDetector) then
device:emit_event(smokeDetector.smoke.clear())
end
device:send(cluster_base.read_manufacturer_specific_attribute(device, Basic.ID, DEVELCO_BASIC_PRIMARY_SW_VERSION_ATTR, DEVELCO_MANUFACTURER_CODE))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: whitespace

@greens greens changed the title Add support to frient heat detector WWSTCERT-8242 Add support to frient heat detector Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants