Skip to content

Add descriptions #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AC19970 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add descriptions #2206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
976271a
Add descriptions
AC19970 Mar 6, 2026
7ba6f67
Update
AC19970 Mar 6, 2026
32bcfe7
Update src/main/resources/assets/skyblocker/lang/en_us.json
AC19970 Mar 6, 2026
8cdcd97
Merge branch 'master' into Internet_Yamero
AC19970 Mar 17, 2026
ebc9d34
Update en_us.json
AC19970 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/de/hysky/skyblocker/config/categories/GeneralCategory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ public static ConfigCategory create(SkyblockerConfig defaults, SkyblockerConfig
.collapsed(true)
.option(Option.<Boolean>createBuilder()
.name(Component.translatable("skyblocker.config.general.itemTooltip.enableNPCPrice"))
.description(Component.translatable("skyblocker.config.general.itemTooltip.enablePrice.@Tooltip"))
.binding(defaults.general.itemTooltip.enableNPCPrice,
() -> config.general.itemTooltip.enableNPCPrice,
newValue -> config.general.itemTooltip.enableNPCPrice = newValue)
Expand All @@ -216,6 +217,7 @@ public static ConfigCategory create(SkyblockerConfig defaults, SkyblockerConfig
.build())
.option(Option.<Boolean>createBuilder()
.name(Component.translatable("skyblocker.config.general.itemTooltip.enableAvgBIN"))
.description(Component.translatable("skyblocker.config.general.itemTooltip.enablePrice.@Tooltip"))
.binding(defaults.general.itemTooltip.enableAvgBIN,
() -> config.general.itemTooltip.enableAvgBIN,
newValue -> config.general.itemTooltip.enableAvgBIN = newValue)
Expand All @@ -231,20 +233,23 @@ public static ConfigCategory create(SkyblockerConfig defaults, SkyblockerConfig
.build())
.option(Option.<Boolean>createBuilder()
.name(Component.translatable("skyblocker.config.general.itemTooltip.enableLowestBIN"))
.description(Component.translatable("skyblocker.config.general.itemTooltip.enablePrice.@Tooltip"))
.binding(defaults.general.itemTooltip.enableLowestBIN,
() -> config.general.itemTooltip.enableLowestBIN,
newValue -> config.general.itemTooltip.enableLowestBIN = newValue)
.controller(ConfigUtils.createBooleanController())
.build())
.option(Option.<Boolean>createBuilder()
.name(Component.translatable("skyblocker.config.general.itemTooltip.enableBazaarPrice"))
.description(Component.translatable("skyblocker.config.general.itemTooltip.enablePrice.@Tooltip"))
.binding(defaults.general.itemTooltip.enableBazaarPrice,
() -> config.general.itemTooltip.enableBazaarPrice,
newValue -> config.general.itemTooltip.enableBazaarPrice = newValue)
.controller(ConfigUtils.createBooleanController())
.build())
.option(Option.<GeneralConfig.Craft>createBuilder()
.name(Component.translatable("skyblocker.config.general.itemTooltip.craft"))
.description(Component.translatable("skyblocker.config.general.itemTooltip.craft.@Tooltip"))
.binding(defaults.general.itemTooltip.enableCraftingCost,
() -> config.general.itemTooltip.enableCraftingCost,
newValue -> config.general.itemTooltip.enableCraftingCost = newValue)
Expand Down
3 changes: 2 additions & 1 deletion src/main/resources/assets/skyblocker/lang/en_us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@
"skyblocker.config.general.itemTooltip.enableAvgBIN": "Enable Avg. BIN Price",
"skyblocker.config.general.itemTooltip.enableBazaarPrice": "Enable Bazaar buy/sell Price",
"skyblocker.config.general.itemTooltip.enableEstimatedItemValue": "Enable Estimated Item Value",
"skyblocker.config.general.itemTooltip.enableEstimatedItemValue.@Tooltip": "Displays an estimation of the item's total value in the tooltip, §lmight not be 100% accurate all the time.§r\n\nWhen selling items always do a manual check of the item price!",
"skyblocker.config.general.itemTooltip.enableEstimatedItemValue.@Tooltip": "Displays an estimation of the item's total value in the tooltip.\nThe price is based on the BZ/AH price of each part, and cannot be accurately estimated when price data is not loaded. Prices may be artificially inflated or deflated so remember to check prices manually before selling items!",
"skyblocker.config.general.itemTooltip.enableEvolvingItemProgress": "Enable Evolving Item Progress",
"skyblocker.config.general.itemTooltip.enableEvolvingItemProgress.@Tooltip": "Displays the age of evolving items and how long they will take to evolve.",
"skyblocker.config.general.itemTooltip.enableExoticTooltip": "Enable Exotic Tooltip",
Expand All @@ -590,6 +590,7 @@
"skyblocker.config.general.itemTooltip.enableMuseumInfo.@Tooltip": "If this item is donatable to the museum, then the item's category in the museum is displayed. It also displays a marker indicating whether you've donated that item to your museum or not (freebies not yet supported).\n\nMake sure to enable your Museum API for accurate information!",
"skyblocker.config.general.itemTooltip.enableNPCPrice": "Enable NPC Price",
"skyblocker.config.general.itemTooltip.enableObtainedDate": "Enable Obtained Date",
"skyblocker.config.general.itemTooltip.enablePrice.@Tooltip": "Price data is loaded via API. If the network fails to load data, please try manually refreshing the data using /skyblocker refreshPrices, or check if the network can access https://hysky.de/api/aaron/authenticate/.",
"skyblocker.config.general.itemTooltip.enableStackingEnchantProgress": "Enable Stacking Enchant Progress",
"skyblocker.config.general.itemTooltip.enableStackingEnchantProgress.@Tooltip": "Displays the progress to the next level of a stacking enchantment if it hasn't been maxed.",
"skyblocker.config.general.itemTooltip.showEssenceCost": "Show Essence Cost",
Expand Down
Loading