Skip to content

Add descriptions#2206

Open
AC19970 wants to merge 5 commits intoSkyblockerMod:masterfrom
AC19970:Internet_Yamero
Open

Add descriptions#2206
AC19970 wants to merge 5 commits intoSkyblockerMod:masterfrom
AC19970:Internet_Yamero

Conversation

@AC19970
Copy link
Contributor

@AC19970 AC19970 commented Mar 6, 2026

There is an achievement in NEEDY GIRL OVERDOSE that requires disconnecting from the internet while playing (actually, being unable to access google.com). What a fitting name I have!

There is an achievement in NEEDY GIRL OVERDOSE that requires disconnecting from the internet while playing (actually, being unable to access google.com). What a fitting name I have!
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Mar 6, 2026
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the links be https://hysky.de/ ?
also don't use formatting codes, make a new text component

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Mar 6, 2026
Copy link
Contributor

@Alex33856 Alex33856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be one translation string

@Alex33856
Copy link
Contributor

shouldn't the links be https://hysky.de/ ?

It should be both

@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Mar 6, 2026
@AC19970
Copy link
Contributor Author

AC19970 commented Mar 6, 2026

shouldn't the links be https://hysky.de/ ? also don't use formatting codes, make a new text component

Some features use Aaron's api, but I don't know which features use hysky's and which features use Aaron's. I've added them all for now.
I don't know who added the formatting code, but it seemed unnecessary, so I removed it.

viciscat
viciscat previously approved these changes Mar 7, 2026
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Mar 7, 2026
@Alex33856
Copy link
Contributor

maybe this should be a label option once those are fixed in Dandelion?

@AC19970
Copy link
Contributor Author

AC19970 commented Mar 10, 2026

maybe this should be a label option once those are fixed in Dandelion?

How could all network issues be fixed? Even if user can access the website, they may not receive a response due to high latency.

@AzureAaron AzureAaron requested a review from Alex33856 March 16, 2026 05:58
@AzureAaron AzureAaron added reviews needed This PR needs reviews and removed merge me please Pull requests that are ready to merge labels Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviews needed This PR needs reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants