Skip to content

Remove style settings as valid setting types #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miazbikowski merged 1 commit into from
Dec 10, 2025
Merged

Remove style settings as valid setting types #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 0 additions & 121 deletions schemas/theme/setting.json
View file
Open in desktop
Copy link
Contributor

@graygilmore graygilmore Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the schema.mdc is bot-generated, right?

Hmmm, I think it might be bot-supplemented but I'm not sure. @aswamy?

Copy link
Contributor

@aswamy aswamy Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. My memory is a bit fuzzy on this. But i think we have to go on Shopify/shopify-dev repo (after you merge this PR), and regenerate the schemas.mdc file there by running rake save_as_md:liquid. Then some GH task will sync that file between the two repos.

cc @karreiro do you know if we have some GH action that can do all of this?

Copy link
Contributor Author

@miazbikowski miazbikowski Dec 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, either way, I'll make sure that happens :)

(so, I tried: https://app.graphite.com/github/pr/Shopify/shopify-dev/65967/Syncing-after-removing-unsupported-theme-settings-from-theme-liquid-docs but the output just filled with junk. I'll inquire with the docs team.)

Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@
"range",
"richtext",
"select",
"style.layout_panel",
"style.size_panel",
"style.spacing_panel",
"text",
"text_alignment",
"textarea",
Expand Down Expand Up @@ -156,18 +153,6 @@
"if": { "required": ["type"], "properties": { "type": { "const": "select" } } },
"then": { "$ref": "#/definitions/select" }
},
{
"if": { "required": ["type"], "properties": { "type": { "const": "style.layout_panel" } } },
"then": { "$ref": "#/definitions/style.layout_panel" }
},
{
"if": { "required": ["type"], "properties": { "type": { "const": "style.size_panel" } } },
"then": { "$ref": "#/definitions/style.size_panel" }
},
{
"if": { "required": ["type"], "properties": { "type": { "const": "style.spacing_panel" } } },
"then": { "$ref": "#/definitions/style.spacing_panel" }
},
{
"if": { "required": ["type"], "properties": { "type": { "const": "text" } } },
"then": { "$ref": "#/definitions/text" }
Expand Down Expand Up @@ -853,112 +838,6 @@
"type": "string",
"pattern": "^-?[0-9]+$"
},

"style.layout_panel": {
"allOf": [
{ "$ref": "#/definitions/inputSettingsStandardAttributes" },
{ "$ref": "#/definitions/conditionalSetting" }
],
"properties": {
"type": {
"const": "style.layout_panel",
"description": "A setting of type style.layout_panel outputs style settings for layout.",
"markdownDescription": "A setting of type `style.layout_panel` outputs style settings for layout.\n\n---\n\n[Shopify reference](https://shopify.dev/docs/themes/architecture/settings/input-settings#style.layout_panel)"
},
"default": {
"allOf": [
{
"$ref": "#/definitions/style.flex_layout_properties"
}
],
"properties": {
"@media (--mobile)": {
"type": "object",
"description": "Style settings for the mobile breakpoint",
"$ref": "#/definitions/style.flex_layout_properties",
"unevaluatedProperties": false
}
},
"unevaluatedProperties": false
},
"label": true,
"info": true,
"id": true,
"visible_if": true
},
"additionalProperties": false
},

"style.size_panel": {
"allOf": [
{ "$ref": "#/definitions/inputSettingsStandardAttributes" },
{ "$ref": "#/definitions/conditionalSetting" }
],
"properties": {
"type": {
"const": "style.size_panel",
"description": "A setting of type style.size_panel outputs style settings for size.",
"markdownDescription": "A setting of type `style.size_panel` outputs style settings for size.\n\n---\n\n[Shopify reference](https://shopify.dev/docs/themes/architecture/settings/input-settings#style.size_panel)"
},
"default": {
"allOf": [
{
"$ref": "#/definitions/style.size_properties"
}
],
"properties": {
"@media (--mobile)": {
"type": "object",
"description": "Style settings for the mobile breakpoint",
"$ref": "#/definitions/style.size_properties",
"unevaluatedProperties": false
}
},
"unevaluatedProperties": false
},
"label": true,
"info": true,
"id": true,
"visible_if": true
},
"additionalProperties": false
},

"style.spacing_panel": {
"allOf": [
{ "$ref": "#/definitions/inputSettingsStandardAttributes" },
{ "$ref": "#/definitions/conditionalSetting" }
],
"properties": {
"type": {
"const": "style.spacing_panel",
"description": "A setting of type style.spacing_panel outputs style settings for spacing.",
"markdownDescription": "A setting of type `style.spacing_panel` outputs style settings for spacing.\n\n---\n\n[Shopify reference](https://shopify.dev/docs/themes/architecture/settings/input-settings#style.spacing_panel)"
},
"default": {
"allOf": [
{
"$ref": "#/definitions/style.spacing_properties"
}
],
"properties": {
"@media (--mobile)": {
"type": "object",
"description": "Style settings for the mobile breakpoint",
"$ref": "#/definitions/style.spacing_properties",
"unevaluatedProperties": false
}
},
"unevaluatedProperties": false
},
"label": true,
"info": true,
"id": true,
"visible_if": true
},
"additionalProperties": false
},

"text": {
"allOf": [
{ "$ref": "#/definitions/inputSettingsStandardAttributes" },
Expand Down
69 changes: 0 additions & 69 deletions tests/fixtures/theme-settings-all-settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,75 +270,6 @@
"id": "paragraph",
"label": "Paragraph"
},
{
"type": "style.layout_panel",
"id": "layout",
"label": "Layout",
"default": {
"flex-direction": "row",
"column-gap": "20px",
"row-gap": "2px",
"flex-wrap": "wrap",
"justify-content": "space-around",
"align-items": "center",
"align-content": "space-between",
"@media (--mobile)": {
"flex-direction": "column",
"gap": "0px"
}
}
},
{
"type": "style.size_panel",
"id": "size",
"label": "Size",
"default": {
"flex-grow": "1",
"flex-shrink": "0",
"flex-basis": "auto",
"width": "100px",
"min-width": "50px",
"max-width": "200px",
"height": "100px",
"min-height": "50px",
"max-height": "200px",
"@media (--mobile)": {
"width": "50px",
"height": "50px"
}
}
},
{
"type": "style.spacing_panel",
"id": "spacing",
"label": "Spacing",
"default": {
"padding": "10px",
"padding-top": "10px",
"padding-right": "15px",
"padding-bottom": "10px",
"padding-left": "15px",
"padding-block-start": "10px",
"padding-block-end": "10px",
"padding-block": "10px 15px",
"padding-inline-start": "15px",
"padding-inline-end": "15px",
"padding-inline": "15px 10px",
"margin": "20px",
"margin-top": "20px",
"margin-right": "25px",
"margin-bottom": "20px",
"margin-left": "25px",
"margin-block-start": "20px",
"@media (--mobile)": {
"margin-block-end": "20px",
"margin-block": "20px 25px",
"margin-inline": "25px 20px",
"margin-inline-start": "25px",
"margin-inline-end": "25px"
}
}
},
{
"type": "text_alignment",
"id": "alignment",
Expand Down
3 changes: 0 additions & 3 deletions tests/test-constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ export const INPUT_SETTING_TYPES = [
'range',
'richtext',
'select',
'style.layout_panel',
'style.size_panel',
'style.spacing_panel',
'text_alignment',
'text',
'textarea',
Expand Down
Loading