-
Notifications
You must be signed in to change notification settings - Fork 20
Remove style settings as valid setting types #1309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
tests/theme-settings/.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yells at invisible system files (removed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the schema.mdc is bot-generated, right?
Hmmm, I think it might be bot-supplemented but I'm not sure. @aswamy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. My memory is a bit fuzzy on this. But i think we have to go on Shopify/shopify-dev repo (after you merge this PR), and regenerate the schemas.mdc file there by running rake save_as_md:liquid. Then some GH task will sync that file between the two repos.
cc @karreiro do you know if we have some GH action that can do all of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, either way, I'll make sure that happens :)
(so, I tried: https://app.graphite.com/github/pr/Shopify/shopify-dev/65967/Syncing-after-removing-unsupported-theme-settings-from-theme-liquid-docs but the output just filled with junk. I'll inquire with the docs team.)
ceb064c to
667d6b9
Compare
Merge activity
|

These settings type are from a cancelled project. Confirmed with the team that we should clean up: https://shopify.slack.com/archives/C03K6LY9SAU/p1765318585508699
Question for reviewer: the schema.mdc is bot-generated, right? (it's the last reference to these settings types)