Skip to content

Conversation

@miazbikowski
Copy link
Contributor

@miazbikowski miazbikowski commented Dec 9, 2025

These settings type are from a cancelled project. Confirmed with the team that we should clean up: https://shopify.slack.com/archives/C03K6LY9SAU/p1765318585508699

Question for reviewer: the schema.mdc is bot-generated, right? (it's the last reference to these settings types)

Copy link
Contributor Author

miazbikowski commented Dec 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@miazbikowski miazbikowski marked this pull request as ready for review December 9, 2025 22:22
@miazbikowski miazbikowski requested a review from a team as a code owner December 9, 2025 22:22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yells at invisible system files (removed)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the schema.mdc is bot-generated, right?

Hmmm, I think it might be bot-supplemented but I'm not sure. @aswamy?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. My memory is a bit fuzzy on this. But i think we have to go on Shopify/shopify-dev repo (after you merge this PR), and regenerate the schemas.mdc file there by running rake save_as_md:liquid. Then some GH task will sync that file between the two repos.

cc @karreiro do you know if we have some GH action that can do all of this?

Copy link
Contributor Author

@miazbikowski miazbikowski Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, either way, I'll make sure that happens :)

(so, I tried: https://app.graphite.com/github/pr/Shopify/shopify-dev/65967/Syncing-after-removing-unsupported-theme-settings-from-theme-liquid-docs but the output just filled with junk. I'll inquire with the docs team.)

Copy link
Contributor Author

miazbikowski commented Dec 10, 2025

Merge activity

  • Dec 10, 9:28 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 10, 9:28 PM UTC: @miazbikowski merged this pull request with Graphite.

@miazbikowski miazbikowski merged commit 5347cec into main Dec 10, 2025
6 checks passed
@miazbikowski miazbikowski deleted the miaz/cleanup-style-settings branch December 10, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants