-
Couldn't load subscription status.
- Fork 853
fix(scheduler): Add scaling config and upgrade paths #6833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lc525
merged 9 commits into
SeldonIO:v2
from
lc525:quickfix/fix-seldonconfig-kafkaconfig-topics
Oct 7, 2025
Merged
fix(scheduler): Add scaling config and upgrade paths #6833
lc525
merged 9 commits into
SeldonIO:v2
from
lc525:quickfix/fix-seldonconfig-kafkaconfig-topics
Oct 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
domsolutions
reviewed
Oct 3, 2025
domsolutions
reviewed
Oct 3, 2025
domsolutions
reviewed
Oct 3, 2025
6f28a51 to
d52eec1
Compare
The new generic config watcher is able to watch configs residing in plain files, files mounted via k8s ConfigMap volumes, and k8s ConfigMaps directly (via informers) when configured.
The operator reads the SeldonConfig and updates a ConfigMap called `seldon-scaling`, which is then mounted by components and watched for changes. The scaling settings from SeldonConfig are also used to validate the replica count of components in SeldonRuntime.
automatically-generated files only, safe to ignore during review
….topics Before Core 2.11, keep the number of partitions and replication factor as microservice environment variables. Those settings are also present in the newly introduced ScalingConfig, but they have no effect atm. This is to ensure a smooth upgrade path, and make it possible in the future to react to changes in those variables by watching the ConfigMap.
…chart values This ensures that for helm-chart users, the smoothest upgrade possible exists: The values will be correctly set in 2.10, and will be then upgradeable at runtime in 2.11.
30d0ad5 to
92e3f4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Motivation
Need for a smooth upgrade path from 2.9.x to 2.10.0. Previously:
The smooth upgrade plan is the following:
SeldonConfig.config.scalingConfig.Pipelines.MaxShardCountMultiplier. An empty scaling config inSeldonConfig.config.scalingConfigis interpreted as ifSeldonConfig.config.scalingConfig.Pipelines.MaxShardCountMultiplier == 1(one processing replica per pipeline/model)SeldonConfig.config.kafkaConfig.Topicscan be set but have no effect -- this is to give customers an opportunity to upgrade their CRs in preparation for 2.11 which will use those settingsSeldonConfig.config.scalingConfig.Pipelines.MaxShardCountMultiplierand this change will propagate automatically through our microservices (this changes the way pipelines/models are sharded over the various microservices: it controls how many replicas of pipeline-gw process a given pipeline, how many dataflow-engine replicas process a given pipeline, and how many model-gw replicas process a given model)What
Summary of changes
SeldonConfig.Config.KafkaConfig.Topics.*settings for microservices (aim to port over to those in 2.11) - leave the config options in place so that customers can upgrade their SeldonConfig progressivelyChecklist
Notes for reviewers
The crux of the changes are in (it would help to review those first):
operator/apis/mlops/v1alpha1/seldonconfig_types.goscheduler/pkg/config/watcher.goscheduler/pkg/scaling/config/config.goscheduler/cmd/scheduler/main.goscheduler/pkg/kafka/dataflow/server.goscheduler/pkg/server/server.go