Skip to content

Conversation

@MiguelAAe
Copy link
Contributor

@MiguelAAe MiguelAAe commented Oct 2, 2025

Why

Issues

When the config from kafka numPartitions is not present or isn't a string the model gateway would fail to create an infer consumer due to the casting of an integer or an empty value from the Topics config.

Motivation

What

Summary of changes

  • update the kafka config logic retrieval of topics to check for either strings or integer and positive integer
  • updated error messages when erroneous config is loaded

Checklist

  • Added/updated unit tests
  • Added/updated documentation
  • Checked for typos in variable names, comments, etc.
  • Added licences for new files

Testing

@MiguelAAe MiguelAAe marked this pull request as ready for review October 2, 2025 13:22
@MiguelAAe MiguelAAe requested a review from lc525 as a code owner October 2, 2025 13:22
@MiguelAAe MiguelAAe requested a review from domsolutions October 2, 2025 13:24
@MiguelAAe MiguelAAe changed the title fix(scheduler): Number of partitions retrieval fix(scheduler, modelgateway): Number of partitions retrieval Oct 2, 2025
@MiguelAAe MiguelAAe added go Pull requests that update Go code v2 labels Oct 2, 2025
@MiguelAAe MiguelAAe changed the title fix(scheduler, modelgateway): Number of partitions retrieval fix(modelgateway): Number of partitions retrieval Oct 2, 2025
@MiguelAAe MiguelAAe requested a review from lc525 October 3, 2025 13:49
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MiguelAAe MiguelAAe merged commit 4d9ec09 into SeldonIO:v2 Oct 3, 2025
3 checks passed
@MiguelAAe MiguelAAe deleted the INFRA-1601/scheduler-panic-numPartitions branch October 3, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants