Skip to content

Removed text from rules banner. #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephenbit wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Removed text from rules banner. #211

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
623867d
Removed text from rules banner. See notes.
stephenbit Sep 5, 2021
569a00b
fixed the functional tests and removed a CSS class
stephenbit Sep 5, 2021
4619664
Updated file names and directories
stephenbit Sep 5, 2021
94ec963
Updated chromedriver
stephenbit Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions functionalTest/test/pageobjects/dashboardPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ class DashboardPage extends Page {
get headingTitle() {
return $(".navbar").$(".heading");
}
get headlineBanner() {
return $(".headline-banner");

@stephenbit stephenbit Sep 5, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now no selector .headline-banner

}
get dailyCases() {
return $("#dailyCases");
}
Expand Down
47 changes: 0 additions & 47 deletions reactDashboard/src/components/RouteMapRules/RouteMapRules.css
View file
Open in desktop

This file was deleted.

39 changes: 8 additions & 31 deletions reactDashboard/src/components/RouteMapRules/RouteMapRules.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,48 +1,25 @@
import React from "react";
import "./RouteMapRules.css";
import Container from "react-bootstrap/Container";
import Row from "react-bootstrap/Row";
import Col from "react-bootstrap/Col";

const RouteMapRules = () => {

@stephenbit stephenbit Sep 5, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the name because it no longer contains any rules.

function createLink(url, text) {
return (
<a
className="link"
id="link"
target="_blank"
rel="noopener noreferrer"
href={url}
>
{text}
</a>
);
}
const HeadlineBanner = () => {
return (
<Container fluid className="d-flex flex-column">
<Row>
<Col className="hr-container">
<Col className="hr-container" style={{ padding: 0 }}>
<hr aria-hidden={true} className="full-width-hr" />
</Col>
</Row>
<Row>
<Col xs="12" className="headline-banner">
<p>
There are a number of{" "}
<span className="headline-banner-highlight">
Regional Restrictions
</span>{" "}
to help fight the pandemic. See the{" "}
{createLink(
"https://www.gov.scot/publications/coronavirus-covid-19-local-measures/",
"latest Scottish Government guidance"
)}
.
</p>
</Col>
<Col
xs="12"
className="headline-banner"
style={{ backgroundColor: "#133a53", padding: "1rem" }}
></Col>
</Row>
</Container>
);
};

export default RouteMapRules;
export default HeadlineBanner;