Removed text from rules banner.#211
Conversation
stephenbit
left a comment
stephenbit
left a comment
There was a problem hiding this comment.
Removed the css file as there was only 2 style selectors left there.
| return $(".navbar").$(".heading"); | ||
| } | ||
| get headlineBanner() { | ||
| return $(".headline-banner"); |
There was a problem hiding this comment.
There is now no selector .headline-banner
| import Row from "react-bootstrap/Row"; | ||
| import Col from "react-bootstrap/Col"; | ||
|
|
||
| const RouteMapRules = () => { |
There was a problem hiding this comment.
Updated the name because it no longer contains any rules.
stephenbit
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
| import Row from "react-bootstrap/Row"; | ||
| import Col from "react-bootstrap/Col"; | ||
|
|
||
| const HeadlineBanner = () => { |
There was a problem hiding this comment.
The only thing I'd suggest is that if a component doesn't do anything, it would be better to inline the static formatting and bin the component.
|
I got a failure on npm start here: Error: No version of chokidar is available. Tried chokidar@2 and chokidar@3. The build failure happens on master too, so likely the issue is me. If npm start works for you, then don't worry about it :) |
2 participants
No description provided.