-
Notifications
You must be signed in to change notification settings - Fork 0
[week6][이진서] 과제 제출 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JINSEO0201
wants to merge
2
commits into
jinseo-week6
Choose a base branch
from
jinseo
base: jinseo-week6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,8 +15,19 @@ function VoteHistoryPage() { | |
|
|
||
| const getImages = async () => { | ||
| try { | ||
| let response; | ||
| let response = await axios.get( | ||
| "https://api.thecatapi.com/v1/votes?limit=8&order=DESC", | ||
| { | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| "x-api-key": | ||
| "live_uJIAOk7Z9jClOkYFxqI4332RzBXawDl1l8L0n9wZehDHhuIW2a7rL92pd2AzyXCX", | ||
| } | ||
| } | ||
| ) | ||
| // ### TO DO ### | ||
| console.log(response) | ||
|
|
||
| // ############# | ||
| const data = response.data; | ||
| const imageSet = []; | ||
|
|
@@ -64,8 +75,9 @@ function VoteHistoryPage() { | |
| <img | ||
| key={img.url} | ||
| src={img.url} | ||
| className={`object-cover w-full h-full border-[3px] border-[#FF6841] rounded-xl | ||
| className={`object-cover w-full h-full border-[3px] rounded-xl | ||
| ### FILL ME ### | ||
| ${img.value > 0 ? "border-red-600" : "border-blue-600"} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 삼항연산자를 활용해 잘 처리하신 것 같습니다! |
||
| `} | ||
| /> | ||
| </div> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,20 +7,73 @@ function VotePage() { | |
| const navigate = useNavigate(); | ||
| const userId = getCookie("userId"); | ||
|
|
||
| const [image, setImage] = useState(); | ||
| const [voteId, setVoteId] = useState(); | ||
| const [thumbsUpImage, setThumbsUpImage] = useState( | ||
| require("../assets/images/thumbs-up-icon.png") | ||
| ); | ||
| const [thumbsDownImage, setThumbsDownImage] = useState( | ||
| require("../assets/images/thumbs-down-icon.png") | ||
| ); | ||
|
|
||
| const [clickThumbsUpImage, setClickThumbsUpImage] = useState( | ||
| require("../assets/images/thumbs-up-click.png") | ||
| ); | ||
| const [clickThumbsDownImage, setClickThumbsDownImage] = useState( | ||
| require("../assets/images/thumbs-down-click.png") | ||
| ); | ||
|
|
||
| const [isHoveringUp, setIsHoveringUp] = useState(false); | ||
| const [isHoveringDown, setIsHoveringDown] = useState(false); | ||
|
|
||
| const handleThumbsUpHover = () => { | ||
| setIsHoveringUp(true); | ||
| }; | ||
|
|
||
| const handleThumbsUpLeave = () => { | ||
| setIsHoveringUp(false); | ||
| }; | ||
|
|
||
| const handleThumbsDownHover = () => { | ||
| setIsHoveringDown(true); | ||
| }; | ||
|
|
||
| const handleThumbsDownLeave = () => { | ||
| setIsHoveringDown(false); | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| getImage(); | ||
| }, []); | ||
|
|
||
| const getImage = async () => { | ||
| try { | ||
| // ### TO DO ### | ||
| const response = await axios.get( | ||
| "https://api.thecatapi.com/v1/images/search?limit=1&size=small", | ||
| { | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| "x-api-key": | ||
| "live_uJIAOk7Z9jClOkYFxqI4332RzBXawDl1l8L0n9wZehDHhuIW2a7rL92pd2AzyXCX", | ||
| }, | ||
| } | ||
| ); | ||
| console.log(response); | ||
| const data = response.data; | ||
|
|
||
| const imageOne = data.map((e) => { | ||
| return e.url; | ||
| }); | ||
|
|
||
| const voteIdOne = data.map((e) => { | ||
| return e.id; | ||
| }); | ||
| console.log(voteIdOne); | ||
|
|
||
| setVoteId(voteIdOne); | ||
|
|
||
| setImage(imageOne); | ||
|
Comment on lines
+65
to
+76
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 두 개를 각각 처리하지 않고 dict를 활용해 한번에 처리할 수도 있을 것 같네요! useState도 하나만 써서 말이죠. 이렇게 하면 불필요한 변수 사용을 줄일 수 있습니다! |
||
| // ############# | ||
| } catch (err) { | ||
| console.log(err); | ||
|
|
@@ -30,7 +83,21 @@ function VotePage() { | |
| const vote = async (val) => { | ||
| try { | ||
| // ### TO DO ### | ||
| // ############# | ||
| const response = await axios.post( | ||
| "https://api.thecatapi.com/v1/votes", | ||
| { | ||
| image_id: voteId, | ||
| sub_id: userId, | ||
| value: val, | ||
| }, | ||
| { | ||
| headers: { | ||
| "Content-Type": "application/json", | ||
| "x-api-key": | ||
| "live_uJIAOk7Z9jClOkYFxqI4332RzBXawDl1l8L0n9wZehDHhuIW2a7rL92pd2AzyXCX", | ||
| }, | ||
| } | ||
| ); | ||
| } catch (err) { | ||
| console.log(err); | ||
| } | ||
|
|
@@ -62,19 +129,24 @@ function VotePage() { | |
| <div className="w-2/3 h-2/3 py-2 border-4 rounded-2xl border-[#FF6841] flex justify-center items-center"> | ||
| <div className="w-full h-[90%] flex justify-evenly items-center"> | ||
| <img | ||
| // ### ONE CAT IMAGE ### | ||
| /* 여기 */ | ||
| src={image} | ||
| className="w-3/5 h-full border-[3px] rounded-xl border-[#FF6841]" | ||
| /> | ||
| <div className="w-1/3 flex gap-12 justify-center"> | ||
| <img | ||
| src={thumbsUpImage} | ||
| src={isHoveringUp ? clickThumbsUpImage : thumbsUpImage} | ||
| className="w-20 h-20 cursor-pointer" | ||
| // ### thumbsUpImage Event ### | ||
| onClick={() => vote(1)} | ||
| onMouseOver={handleThumbsUpHover} | ||
| onMouseOut={handleThumbsUpLeave} | ||
| /> | ||
| <img | ||
| src={thumbsDownImage} | ||
| src={isHoveringDown ? clickThumbsDownImage : thumbsDownImage} | ||
| className="w-20 h-20 cursor-pointer" | ||
| // ### thumbsDownImage Event ### | ||
| onClick={() => vote(-1)} | ||
| onMouseOver={handleThumbsDownHover} | ||
| onMouseOut={handleThumbsDownLeave} | ||
| /> | ||
| </div> | ||
| </div> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR을 날릴 때 이런 console.log 들은 정리하시는 습관을 들이는게 좋습니다!