Open
Conversation
unknownburphy
approved these changes
May 3, 2024
| } | ||
| ) | ||
| // ### TO DO ### | ||
| console.log(response) |
There was a problem hiding this comment.
PR을 날릴 때 이런 console.log 들은 정리하시는 습관을 들이는게 좋습니다!
| className={`object-cover w-full h-full border-[3px] border-[#FF6841] rounded-xl | ||
| className={`object-cover w-full h-full border-[3px] rounded-xl | ||
| ### FILL ME ### | ||
| ${img.value > 0 ? "border-red-600" : "border-blue-600"} |
Comment on lines
+65
to
+76
| const imageOne = data.map((e) => { | ||
| return e.url; | ||
| }); | ||
|
|
||
| const voteIdOne = data.map((e) => { | ||
| return e.id; | ||
| }); | ||
| console.log(voteIdOne); | ||
|
|
||
| setVoteId(voteIdOne); | ||
|
|
||
| setImage(imageOne); |
There was a problem hiding this comment.
두 개를 각각 처리하지 않고 dict를 활용해 한번에 처리할 수도 있을 것 같네요! useState도 하나만 써서 말이죠. 이렇게 하면 불필요한 변수 사용을 줄일 수 있습니다!
minseo25
reviewed
May 4, 2024
minseo25
left a comment
minseo25
left a comment
There was a problem hiding this comment.
전체적으로 깔끔하게 코드를 잘 짜신 것 같습니다!
console.log() 만 정리하면 완벽할 것 같아요~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💎 과제 구현 설명
🏁 PR 체크리스트
🖼️ Screenshot / Video
🙌 Issue