ocb3: migrate internals to use inout #667
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
commented
Mar 17, 2025
|
I couldn't figure out a way to test inout here with two separate buffers, but this gets tested in #665 when it's plugged with |
baloo
force-pushed
the
baloo/ocb3/inout
branch
2 times, most recently
from
1d3e113 to
3eddf5a
Compare
tarcieri
reviewed
Mar 25, 2025
ocb3/src/lib.rs
Outdated
| pub(crate) type Block = Array<u8, U16>; | ||
| type BlockSize = U16; | ||
| pub(crate) type Block = Array<u8, BlockSize>; | ||
| type DoubleBlock = Array<u8, <BlockSize as Mul<U2>>::Output>; |
There was a problem hiding this comment.
Alternatively you can use Add instead of Mul<U2> (where Add implicitly takes Self as a default) e.g. https://github.com/RustCrypto/AEADs/blob/a09f3d2/aes-siv/src/siv.rs#L101
There was a problem hiding this comment.
It's an internal type, I think it's better to be explicit about the intent?
Relying on the implicit value of Add makes it harder to read imho.
baloo
force-pushed
the
baloo/ocb3/inout
branch
2 times, most recently
from
0aeac3f to
42e4e95
Compare
baloo
force-pushed
the
baloo/ocb3/inout
branch
3 times, most recently
from
e5ff157 to
54a2f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prepare the migration to
AeadInOut, following RustCrypto/traits#1793Depends: