Skip to content

Migrate to AeadInOut #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Migrate to AeadInOut #665

wants to merge 9 commits into from

Conversation

baloo
Copy link
Member

@baloo baloo commented Mar 14, 2025 •
edited
Loading

baloo
baloo commented Mar 14, 2025
View reviewed changes
aes-gcm/tests/common/mod.rs Outdated
for vector in $vectors {
let key = Array(*vector.key);
let nonce = Array(*vector.nonce);
let mut payload = BicephalBuffer::from(vector.plaintext);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes use of RustCrypto/traits#1797

@baloo baloo marked this pull request as draft March 14, 2025 21:54
@newpavlov
Copy link
Member

I would wait with this migration a bit. I plan to open several PRs to change aead APIs further and we probably will need to discuss them a fair amount.

@baloo
Copy link
Member Author

baloo commented Mar 14, 2025

I don't mind waiting to merge but I'll get this branch to a point where it can be used in a [patch.crates-io] by a consumer which is not currently the case with master.

@tarcieri
Copy link
Member

tarcieri commented Mar 14, 2025 •
edited
Loading

It would definitely be nice to get things in sync with master if we can. There are people who are trying to track these repos as git dependencies and that becomes difficult when they go out-of-sync. Ideally we'd have a PR to update the downstream repos ready to go before we merge changes in traits, which is my bad

@baloo baloo mentioned this pull request Mar 16, 2025
Merged
@baloo baloo force-pushed the baloo/inout-v2 branch 2 times, most recently from b37f66c to 96a264b Compare March 17, 2025 05:54
@baloo baloo mentioned this pull request Mar 17, 2025
Open
@baloo baloo force-pushed the baloo/inout-v2 branch 11 times, most recently from 34abf4d to c333a41 Compare March 17, 2025 20:49
@baloo baloo mentioned this pull request Mar 17, 2025
Closed
@baloo baloo force-pushed the baloo/inout-v2 branch 2 times, most recently from fdc90c2 to 1bd4230 Compare March 18, 2025 03:08
@baloo baloo mentioned this pull request Mar 18, 2025
Closed
@baloo
Copy link
Member Author

baloo commented Mar 21, 2025

I'll need to sort out the lack of MockBuffer for ascon and deoxys: RustCrypto/traits#1802 (comment)

@baloo baloo force-pushed the baloo/inout-v2 branch 4 times, most recently from 40846f9 to 90ddf77 Compare March 24, 2025 21:55
baloo and others added 3 commits March 31, 2025 09:32
@baloo
ocb3: migrate internals to use inout
d4fbee9
@baloo
ocb3: remove useless loops
e0456c2
@tarcieri @baloo
Migrate to AeadInOut
92f921c 
Replaces the previous `AeadInPlaceDetached` impls with `AeadInOut`,
which was introduced in RustCrypto/traits#1793
@baloo baloo mentioned this pull request Apr 11, 2025
Draft
@baloo baloo force-pushed the baloo/inout-v2 branch 2 times, most recently from a3ed8d8 to c1326b6 Compare April 14, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baloo @newpavlov @tarcieri