fix broken translation images and Vietnam link #1043
+22
−14
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -8,17 +8,25 @@ Head over to [contribution guide](https://github.com/Roshanjossey/code-contribut | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| #### _Read this in [other languages](docs/translations/Translations.md)._ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="Deutsch" alt="Deutsch" src="https://upload.wikimedia.org/wikipedia/commons/b/ba/Flag_of_Germany.svg" width="22">](docs/translations/de/README.de.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="Português (Brasil)" alt="Português (Brasil)" src="https://upload.wikimedia.org/wikipedia/commons/0/05/Flag_of_Brazil.svg" width="22">](docs/translations/pt_br/README.pt_br.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="日本語" alt="日本語" src="https://upload.wikimedia.org/wikipedia/commons/9/9e/Flag_of_Japan.svg" width="22">](docs/translations/ja/README.ja.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="Bahasa Indonesia" alt="Bahasa Indonesia" src="https://upload.wikimedia.org/wikipedia/commons/9/9f/Flag_of_Indonesia.svg" width="22">](docs/translations/id/README.id.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="中文" alt="中文" src="https://upload.wikimedia.org/wikipedia/commons/f/fa/Flag_of_the_People%27s_Republic_of_China.svg" width="22">](docs/translations/cn/README.cn.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="Español de España" alt="Español de España" src="https://upload.wikimedia.org/wikipedia/commons/9/9a/Flag_of_Spain.svg" width="22">](docs/translations/es/README.es.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="Türkiye" alt="Türkiye" src="https://upload.wikimedia.org/wikipedia/commons/b/b4/Flag_of_Turkey.svg" width="22">](docs/translations/tr/README.tr.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="فارسی" alt="فارسی" src="https://upload.wikimedia.org/wikipedia/commons/b/ba/Flag_of_Iran_before_1979_Revolution.svg" width="22">](docs/translations/fa/README.fa.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="Italiano" alt="Italiano" src="https://upload.wikimedia.org/wikipedia/commons/0/03/Flag_of_Italy.svg" width="22">](docs/translations/it/README.it.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="العربية" alt="العربية" src="https://upload.wikimedia.org/wikipedia/commons/0/0d/Flag_of_Saudi_Arabia.svg" width="22">](docs/translations/ar/README.ar.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="한국어" alt="한국어" src="https://upload.wikimedia.org/wikipedia/commons/0/09/Flag_of_South_Korea.svg" width="22">](docs/translations/kr/README.kr.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="Vietnam" alt="Vietnam" src="https://upload.wikimedia.org/wikipedia/commons/2/21/Flag_of_Vietnam.svg" width="22">](docs/translations/vn/README.vn.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="Polish" alt="Polish" src="https://upload.wikimedia.org/wikipedia/commons/1/12/Flag_of_Poland.svg" width="22">](docs/translations/pl/README.pl.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| <kbd>[<img title="Russian" alt="Russian" src="https://upload.wikimedia.org/wikipedia/commons/f/f3/Flag_of_Russia.svg" width="22">](docs/translations/ru/README.ru.md)</kbd> | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+11
to
+24
There was a problem hiding this comment. This change switches all flag icons from the repo’s previously used
Suggested change
Author
There was a problem hiding this comment. I updated the other translation index to match so the asset source stays consistent. And I also added Persian and Polish to Translations.md |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+25
to
+32
There was a problem hiding this comment. There are multiple trailing blank lines at the end of the README after the language links. Please trim these extra empty lines to keep the file clean and avoid unnecessary diff churn.
Suggested change
Author
There was a problem hiding this comment. it was before, I thought it's intended |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Farsi entry is using
Flag_of_Iran_before_1979_Revolution.svg, which is not the current Iranian flag and is likely unintended for a language selector. Consider switching to the standard current flag asset (or reverting to the previousir.svg) so the icon matches user expectations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proposed flag by Copilot is corrupted with arab letters and offensive symbon in the middle. This is not actual flag of Iranian nation