fix broken translation images and Vietnam link by Piesikot · Pull Request #1043 · Roshanjossey/code-contributions

Piesikot · 2026-03-30T13:45:00Z

Before submitting this pull request, please go through the checklist below.
If you're doing something in the checklist, put an x inside [ ] so that - [ ] becomes - [x]

I have added a screenshot from browser with my changes
There are no errors in the console
I had fun going through this tutorial (ノ^o^)ノ and learned on the way ٩(＾◡＾)۶
There are some things I'd like to improve in this tutorial. I have written them below.
- Spain image path was broken
- العربية image path was broken
- Farsi image was broken
- Vietnam link pointed to the wrong file

- Spain image was broken - العربية image path was broken - Farsi image was broken - Vietnam link pointed to the wrong file

Copilot

Pull request overview

Updates the top-level README’s “Read this in other languages” section to fix broken flag images and correct the Vietnam translation link.

Changes:

Replaced flag image sources for all language links in README.md.
Corrected the Vietnam translation link to point to README.vn.md.
Adjusted some language labels (e.g., Spain/Farsi display names).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-30T13:47:33Z

README.md

+<kbd>[<img title="中文" alt="中文" src="https://upload.wikimedia.org/wikipedia/commons/f/fa/Flag_of_the_People%27s_Republic_of_China.svg" width="22">](docs/translations/cn/README.cn.md)</kbd>
+<kbd>[<img title="Español de España" alt="Español de España" src="https://upload.wikimedia.org/wikipedia/commons/9/9a/Flag_of_Spain.svg" width="22">](docs/translations/es/README.es.md)</kbd>
+<kbd>[<img title="Türkiye" alt="Türkiye" src="https://upload.wikimedia.org/wikipedia/commons/b/b4/Flag_of_Turkey.svg" width="22">](docs/translations/tr/README.tr.md)</kbd>
+<kbd>[<img title="فارسی" alt="فارسی" src="https://upload.wikimedia.org/wikipedia/commons/b/ba/Flag_of_Iran_before_1979_Revolution.svg" width="22">](docs/translations/fa/README.fa.md)</kbd>


The Farsi entry is using Flag_of_Iran_before_1979_Revolution.svg, which is not the current Iranian flag and is likely unintended for a language selector. Consider switching to the standard current flag asset (or reverting to the previous ir.svg) so the icon matches user expectations.

Suggested change

<kbd>[<img title="فارسی" alt="فارسی" src="https://upload.wikimedia.org/wikipedia/commons/b/ba/Flag_of_Iran_before_1979_Revolution.svg" width="22">](docs/translations/fa/README.fa.md)</kbd>

<kbd>[<img title="فارسی" alt="فارسی" src="https://upload.wikimedia.org/wikipedia/commons/c/ca/Flag_of_Iran.svg" width="22">](docs/translations/fa/README.fa.md)</kbd>

proposed flag by Copilot is corrupted with arab letters and offensive symbon in the middle. This is not actual flag of Iranian nation

Copilot · 2026-03-30T13:47:33Z

README.md

+
+
+
+
+
+
+
+


There are multiple trailing blank lines at the end of the README after the language links. Please trim these extra empty lines to keep the file clean and avoid unnecessary diff churn.

Suggested change

it was before, I thought it's intended

Copilot · 2026-03-30T13:47:34Z

README.md

+<kbd>[<img title="Deutsch" alt="Deutsch" src="https://upload.wikimedia.org/wikipedia/commons/b/ba/Flag_of_Germany.svg" width="22">](docs/translations/de/README.de.md)</kbd>
+<kbd>[<img title="Português (Brasil)" alt="Português (Brasil)" src="https://upload.wikimedia.org/wikipedia/commons/0/05/Flag_of_Brazil.svg" width="22">](docs/translations/pt_br/README.pt_br.md)</kbd>
+<kbd>[<img title="日本語" alt="日本語" src="https://upload.wikimedia.org/wikipedia/commons/9/9e/Flag_of_Japan.svg" width="22">](docs/translations/ja/README.ja.md)</kbd>
+<kbd>[<img title="Bahasa Indonesia" alt="Bahasa Indonesia" src="https://upload.wikimedia.org/wikipedia/commons/9/9f/Flag_of_Indonesia.svg" width="22">](docs/translations/id/README.id.md)</kbd>
+<kbd>[<img title="中文" alt="中文" src="https://upload.wikimedia.org/wikipedia/commons/f/fa/Flag_of_the_People%27s_Republic_of_China.svg" width="22">](docs/translations/cn/README.cn.md)</kbd>
+<kbd>[<img title="Español de España" alt="Español de España" src="https://upload.wikimedia.org/wikipedia/commons/9/9a/Flag_of_Spain.svg" width="22">](docs/translations/es/README.es.md)</kbd>
+<kbd>[<img title="Türkiye" alt="Türkiye" src="https://upload.wikimedia.org/wikipedia/commons/b/b4/Flag_of_Turkey.svg" width="22">](docs/translations/tr/README.tr.md)</kbd>
+<kbd>[<img title="فارسی" alt="فارسی" src="https://upload.wikimedia.org/wikipedia/commons/b/ba/Flag_of_Iran_before_1979_Revolution.svg" width="22">](docs/translations/fa/README.fa.md)</kbd>
+<kbd>[<img title="Italiano" alt="Italiano" src="https://upload.wikimedia.org/wikipedia/commons/0/03/Flag_of_Italy.svg" width="22">](docs/translations/it/README.it.md)</kbd>
+<kbd>[<img title="العربية" alt="العربية" src="https://upload.wikimedia.org/wikipedia/commons/0/0d/Flag_of_Saudi_Arabia.svg" width="22">](docs/translations/ar/README.ar.md)</kbd>
+<kbd>[<img title="한국어" alt="한국어" src="https://upload.wikimedia.org/wikipedia/commons/0/09/Flag_of_South_Korea.svg" width="22">](docs/translations/kr/README.kr.md)</kbd>
+<kbd>[<img title="Vietnam" alt="Vietnam" src="https://upload.wikimedia.org/wikipedia/commons/2/21/Flag_of_Vietnam.svg" width="22">](docs/translations/vn/README.vn.md)</kbd>
+<kbd>[<img title="Polish" alt="Polish" src="https://upload.wikimedia.org/wikipedia/commons/1/12/Flag_of_Poland.svg" width="22">](docs/translations/pl/README.pl.md)</kbd>
+<kbd>[<img title="Russian" alt="Russian" src="https://upload.wikimedia.org/wikipedia/commons/f/f3/Flag_of_Russia.svg" width="22">](docs/translations/ru/README.ru.md)</kbd>


This change switches all flag icons from the repo’s previously used cdn.statically.io/gh/hjnilsson/country-flags assets to upload.wikimedia.org. Elsewhere (e.g., docs/translations/Translations.md) the old asset source is still used, so the project now depends on two different external hosts for the same UI element. Consider either fixing only the broken URLs while keeping the existing flag source, or updating the other translation index to match so the asset source stays consistent.

Suggested change

<kbd>[<img title="Deutsch" alt="Deutsch" src="https://upload.wikimedia.org/wikipedia/commons/b/ba/Flag_of_Germany.svg" width="22">](docs/translations/de/README.de.md)</kbd>

<kbd>[<img title="Português (Brasil)" alt="Português (Brasil)" src="https://upload.wikimedia.org/wikipedia/commons/0/05/Flag_of_Brazil.svg" width="22">](docs/translations/pt_br/README.pt_br.md)</kbd>

<kbd>[<img title="日本語" alt="日本語" src="https://upload.wikimedia.org/wikipedia/commons/9/9e/Flag_of_Japan.svg" width="22">](docs/translations/ja/README.ja.md)</kbd>

<kbd>[<img title="Bahasa Indonesia" alt="Bahasa Indonesia" src="https://upload.wikimedia.org/wikipedia/commons/9/9f/Flag_of_Indonesia.svg" width="22">](docs/translations/id/README.id.md)</kbd>

<kbd>[<img title="中文" alt="中文" src="https://upload.wikimedia.org/wikipedia/commons/f/fa/Flag_of_the_People%27s_Republic_of_China.svg" width="22">](docs/translations/cn/README.cn.md)</kbd>

<kbd>[<img title="Español de España" alt="Español de España" src="https://upload.wikimedia.org/wikipedia/commons/9/9a/Flag_of_Spain.svg" width="22">](docs/translations/es/README.es.md)</kbd>

<kbd>[<img title="Türkiye" alt="Türkiye" src="https://upload.wikimedia.org/wikipedia/commons/b/b4/Flag_of_Turkey.svg" width="22">](docs/translations/tr/README.tr.md)</kbd>

<kbd>[<img title="فارسی" alt="فارسی" src="https://upload.wikimedia.org/wikipedia/commons/b/ba/Flag_of_Iran_before_1979_Revolution.svg" width="22">](docs/translations/fa/README.fa.md)</kbd>

<kbd>[<img title="Italiano" alt="Italiano" src="https://upload.wikimedia.org/wikipedia/commons/0/03/Flag_of_Italy.svg" width="22">](docs/translations/it/README.it.md)</kbd>

<kbd>[<img title="العربية" alt="العربية" src="https://upload.wikimedia.org/wikipedia/commons/0/0d/Flag_of_Saudi_Arabia.svg" width="22">](docs/translations/ar/README.ar.md)</kbd>

<kbd>[<img title="한국어" alt="한국어" src="https://upload.wikimedia.org/wikipedia/commons/0/09/Flag_of_South_Korea.svg" width="22">](docs/translations/kr/README.kr.md)</kbd>

<kbd>[<img title="Vietnam" alt="Vietnam" src="https://upload.wikimedia.org/wikipedia/commons/2/21/Flag_of_Vietnam.svg" width="22">](docs/translations/vn/README.vn.md)</kbd>

<kbd>[<img title="Polish" alt="Polish" src="https://upload.wikimedia.org/wikipedia/commons/1/12/Flag_of_Poland.svg" width="22">](docs/translations/pl/README.pl.md)</kbd>

<kbd>[<img title="Russian" alt="Russian" src="https://upload.wikimedia.org/wikipedia/commons/f/f3/Flag_of_Russia.svg" width="22">](docs/translations/ru/README.ru.md)</kbd>

<kbd>[<img title="Deutsch" alt="Deutsch" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/de.svg" width="22">](docs/translations/de/README.de.md)</kbd>

<kbd>[<img title="Português (Brasil)" alt="Português (Brasil)" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/br.svg" width="22">](docs/translations/pt_br/README.pt_br.md)</kbd>

<kbd>[<img title="日本語" alt="日本語" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/jp.svg" width="22">](docs/translations/ja/README.ja.md)</kbd>

<kbd>[<img title="Bahasa Indonesia" alt="Bahasa Indonesia" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/id.svg" width="22">](docs/translations/id/README.id.md)</kbd>

<kbd>[<img title="中文" alt="中文" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/cn.svg" width="22">](docs/translations/cn/README.cn.md)</kbd>

<kbd>[<img title="Español de España" alt="Español de España" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/es.svg" width="22">](docs/translations/es/README.es.md)</kbd>

<kbd>[<img title="Türkiye" alt="Türkiye" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/tr.svg" width="22">](docs/translations/tr/README.tr.md)</kbd>

<kbd>[<img title="فارسی" alt="فارسی" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/ir.svg" width="22">](docs/translations/fa/README.fa.md)</kbd>

<kbd>[<img title="Italiano" alt="Italiano" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/it.svg" width="22">](docs/translations/it/README.it.md)</kbd>

<kbd>[<img title="العربية" alt="العربية" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/sa.svg" width="22">](docs/translations/ar/README.ar.md)</kbd>

<kbd>[<img title="한국어" alt="한국어" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/kr.svg" width="22">](docs/translations/kr/README.kr.md)</kbd>

<kbd>[<img title="Vietnam" alt="Vietnam" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/vn.svg" width="22">](docs/translations/vn/README.vn.md)</kbd>

<kbd>[<img title="Polish" alt="Polish" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/pl.svg" width="22">](docs/translations/pl/README.pl.md)</kbd>

<kbd>[<img title="Russian" alt="Russian" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/ru.svg" width="22">](docs/translations/ru/README.ru.md)</kbd>

I updated the other translation index to match so the asset source stays consistent. And I also added Persian and Polish to Translations.md

fix broken translation images and Vietnam link

740b43e

- Spain image was broken - العربية image path was broken - Farsi image was broken - Vietnam link pointed to the wrong file

Copilot AI review requested due to automatic review settings March 30, 2026 13:45

Copilot started reviewing on behalf of Piesikot March 30, 2026 13:45 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix broken translation images and Vietnam link#1043

fix broken translation images and Vietnam link#1043
Piesikot wants to merge 1 commit intoRoshanjossey:mainfrom
Piesikot:fix-README

Piesikot commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Piesikot Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Piesikot Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Piesikot Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	<kbd>[<img title="فارسی" alt="فارسی" src="https://upload.wikimedia.org/wikipedia/commons/b/ba/Flag_of_Iran_before_1979_Revolution.svg" width="22">](docs/translations/fa/README.fa.md)</kbd>
	<kbd>[<img title="فارسی" alt="فارسی" src="https://upload.wikimedia.org/wikipedia/commons/c/ca/Flag_of_Iran.svg" width="22">](docs/translations/fa/README.fa.md)</kbd>

Conversation

Piesikot commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Piesikot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Piesikot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Piesikot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants