Skip to content

[Improve] Clarify Review Code copy on Automations#489

Merged
brunobergher merged 8 commits into
developfrom
improve/automations-review-code-copy-3tsziqhaou7ol
Jul 17, 2026
Merged

[Improve] Clarify Review Code copy on Automations#489
brunobergher merged 8 commits into
developfrom
improve/automations-review-code-copy-3tsziqhaou7ol

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Bruno Bergher. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

Internal UX polish from product feedback on Automations.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Automations page cleanup:

  • Review Code copy/order/helpers
  • Section layout: Source Code automations first, then Slack, managers, Meta automations
  • Rolled back dynamic/configured provider badges after review: restored descriptor-based GitHub only / middot badges so empty intersections no longer look like full support

How it was tested

  • vitest run AutomationsSettings.render.client.test.tsx
  • Pre-push checks
  • Manual browser check of /automations

Checklist

  • The PR title follows the repo convention
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

Screenshots

Classic capability badges restored

Update Review Code toggle labels and helpers, and remove the redundant
"Which PRs get reviewed?" info box.
@roomote-roomote

roomote-roomote Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

No new code issues found. See task

  • apps/web/src/components/settings/automations/AutomationsSettings.tsx:2687 says automatic review covers “any new PRs,” but reviewerReviewAllPullRequestAuthors defaults to false and filters out PRs not opened by Roomote. Describe these as eligible/in-scope PRs so this toggle does not contradict the author-scope toggle below it.
  • apps/web/src/components/settings/automations/AutomationsSettings.tsx:2712 says disabling draft reviews means Roomote will “only review PRs marked as ready,” but reviewDraftPrs controls automatic reviews only; an @-mention can still request review on a draft. Scope the helper to automatic reviews so users are not told that drafts are globally excluded.
  • apps/web/src/components/settings/automations/AutomationsSettings.tsx:382 suppresses the capability badge when none of an automation's supported providers overlap the multiple configured providers. For example, a GitLab + Azure DevOps deployment shows no limitation badge on the GitHub-only Dependabot, CodeQL, and CI triage cards, which is the same visual signal as full support; render an explicit unsupported state instead of dropping the badge for an empty intersection.

Reviewed b9ff725

roomote added 7 commits July 17, 2026 13:40
Swap nested Review Code toggle order so draft PRs appear before
non-Roomote authors.
Add a Source Code automations section after Slack, rename Other to Meta,
and render “For X only” capability badges from configured providers only.
Surface SCM automations first; Slack automations follow as a secondary group.
Drop “any” from auto-review scope and clarify draft helper is for
automatic reviews only.
Restore descriptor-based “GitHub only” / “Slack · Discord only” badges
so empty provider intersections no longer look like full support.
@brunobergher
brunobergher marked this pull request as ready for review July 17, 2026 14:17
@brunobergher
brunobergher merged commit 2b99681 into develop Jul 17, 2026
17 checks passed
@brunobergher
brunobergher deleted the improve/automations-review-code-copy-3tsziqhaou7ol branch July 17, 2026 14:17
@roomote-roomote roomote-roomote Bot mentioned this pull request Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants