[Fix] Slack transcripts crash on long thread activity sequences#488
Merged
mrubens merged 1 commit intoJul 17, 2026
Merged
Conversation
Replace recursive thread_activity traversal with an iterative, memoized parser so thousands of sequential activity blocks cannot blow the call stack.
Contributor
Author
mrubens
marked this pull request as ready for review
July 17, 2026 13:24
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 17, 2026 13:24
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Replaced recursive Slack transcript wrapper parsing with an iterative, memoized implementation so long sequences of valid
<thread_activity>blocks no longer blow the call stack while extracting or hiding transcript text.Why this change was made
A review finding on the v0.8.0 promote PR showed that sequential
<thread_activity>blocks still consumed one stack frame each. About 2,000 well-formed blocks (~78 KB) madenormalizeTranscriptUserTextthrowRangeError: Maximum call stack size exceeded, so crafted or heavy thread activity could still break transcript processing after the earlier regex hang fix.Impact
Slack transcript normalization and visibility handling stay behavior-compatible for normal wrappers, including lookalike closers and mixed activity/context/message shapes, but large sequential thread-activity payloads no longer crash with a call-stack overflow.