[Fix] Develop CI Type Check fails on duplicate worker runtime schema import#310
Closed
roomote-roomote[bot] wants to merge 1 commit into
Closed
Conversation
Contributor
Author
daniel-lxs
added a commit
that referenced
this pull request
Jul 14, 2026
Same one-line fix as #310; keeps this branch typechecking until that lands on develop. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
daniel-lxs
added a commit
that referenced
this pull request
Jul 14, 2026
…305) * Post announcer and manager-stats reports via communication adapters The last two Slack-hardwired automation reporters now reach Teams and Telegram destinations. Slack destinations keep the existing SlackNotifier + Block Kit path byte-identical; non-Slack destinations post through getCommunicationProviderAdapter with the summary degraded from Slack mrkdwn to standard markdown (new degradeSlackMrkdwnToMarkdown helper), the settings-link footer becoming a cross-surface url button, detail messages threaded under the root, and tracked automation threads upserted with the destination surface. Deployment eligibility generalizes like the triage runner: Slack installations first, otherwise any connected communication provider (manager-stats resolves its GitHub actor from the installation row on Slack-less deployments). Registry declarations flip to slack/teams/telegram for both. ci_failure_triage and the suggester's advanced routing intentionally stay Slack-only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Dedupe worker runtime schema import inherited from develop Same one-line fix as #310; keeps this branch typechecking until that lands on develop. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Member
|
Obsolete: #305 carried the identical dedupe; develop typechecks clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Not tracked as a standalone GitHub issue. Fixes the develop CI Type Check regression introduced by #307 (
WORKER_RUNTIME_SCHEMA_VERSIONimported twice inapps/websetup-new tests). Fail run: https://github.com/RooCodeInc/Roomote/actions/runs/29294274110Why this PR exists
What changed
Removed a duplicate
WORKER_RUNTIME_SCHEMA_VERSIONimport from the setup-new command tests so TypeScript no longer reportsTS2300: Duplicate identifier. The symbol remains imported once from@roomote/typeswith the other runtime schema fixtures used in those tests.Why this change was made
Develop CI Type Check went red after #307 merged with two imports of the same constant in the same file. This is the smallest fix that restores green type checking without reworking related runtime-schema fixture PRs.
Impact
No intended product behavior change. Restores develop Type Check /
@roomote/webtype checking so CI can pass again for later merges.How it was tested
@roomote/webcheck-types error (TS2300on the duplicate import) on develop head.pnpm --filter @roomote/web check-typespasses.lint:fast,check-types:fast,knip) passed on push.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset