Skip to content

Fix compute provisioning tests for the r3 runtime schema bump#309

Closed
daniel-lxs wants to merge 1 commit into
developfrom
fix/worker-runtime-tag-test-expectations
Closed

Fix compute provisioning tests for the r3 runtime schema bump#309
daniel-lxs wants to merge 1 commit into
developfrom
fix/worker-runtime-tag-test-expectations

Conversation

@daniel-lxs

Copy link
Copy Markdown
Member

What

develop is red: #301 bumped WORKER_RUNTIME_SCHEMA_VERSION 2→3, but its merge CI path-filtered away the apps/web test suite, so seven stale test expectations surfaced only when later merges (#291) touched apps/web and made CI actually run them.

No runtime bug#301 never touched the provisioning currency logic; verified against its diff. This is test-only:

  • "Current" fixtures use WORKER_RUNTIME_SCHEMA_VERSION / WORKER_RUNTIME_SCHEMA_TAG instead of hardcoded 2 / -r2, so future bumps don't break them
  • The compute-providers derivation stubs now importOriginal, so fixtures and assertions exercise the real templateRef derivations instead of hand-rolled suffix-less strings
  • Two tests that kept passing after the bump for the wrong reason (fixtures silently became "stale", flipping them onto untested paths) are re-anchored to the current version with strengthened assertions

Testing

  • Full apps/web suite: 281 files / 1969 tests green (was 7 red on develop)
  • check-types:fast, prettier clean

Unblocks develop and #305.

🤖 Generated with Claude Code

PR #301 bumped WORKER_RUNTIME_SCHEMA_VERSION 2->3 but path-filtered CI
never ran the apps/web suite, leaving develop red once later merges
touched apps/web. No runtime bug: the provisioning currency logic was
unchanged. Fixture and assertion fixes only:

- current-state fixtures use WORKER_RUNTIME_SCHEMA_VERSION /
  WORKER_RUNTIME_SCHEMA_TAG instead of hardcoded 2 / -r2
- derivation stubs replaced with importOriginal so tests exercise the
  real templateRef derivations
- two tests that silently passed for the wrong reason after the bump
  (reconcile skip-current, supersession) re-anchored to the current
  version with strengthened assertions

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@roomote-roomote

roomote-roomote Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

This is a clean, test-only change. The "current" fixtures and assertions now derive templateRef from WORKER_RUNTIME_SCHEMA_TAG and WORKER_RUNTIME_SCHEMA_VERSION, and switching the @roomote/compute-providers mock to importOriginal correctly exercises the real deriveE2bWorkerTemplateRef / deriveDaytonaWorkerSnapshotName derivations (verified against packages/compute-providers/src/e2b/build-e2b-template.ts and .../daytona/register-daytona-snapshot.ts). Ran the three changed suites locally: 71 tests pass.

Note (non-blocking): the PR currently reports a merge conflict with develop — a rebase/merge will be needed before it can land.

Reviewed fa0cf4f

@daniel-lxs

Copy link
Copy Markdown
Member Author

Superseded: develop absorbed #304 (same test fix via the CI-failure automation) plus the #306/#307 provisioning rework while this was queued, and #310 handles the remaining duplicate-import typecheck error. Closing.

@daniel-lxs daniel-lxs closed this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant