Fix compute provisioning tests for the r3 runtime schema bump#309
Closed
daniel-lxs wants to merge 1 commit into
Closed
Fix compute provisioning tests for the r3 runtime schema bump#309daniel-lxs wants to merge 1 commit into
daniel-lxs wants to merge 1 commit into
Conversation
PR #301 bumped WORKER_RUNTIME_SCHEMA_VERSION 2->3 but path-filtered CI never ran the apps/web suite, leaving develop red once later merges touched apps/web. No runtime bug: the provisioning currency logic was unchanged. Fixture and assertion fixes only: - current-state fixtures use WORKER_RUNTIME_SCHEMA_VERSION / WORKER_RUNTIME_SCHEMA_TAG instead of hardcoded 2 / -r2 - derivation stubs replaced with importOriginal so tests exercise the real templateRef derivations - two tests that silently passed for the wrong reason after the bump (reconcile skip-current, supersession) re-anchored to the current version with strengthened assertions Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
No code issues found. See task This is a clean, test-only change. The "current" fixtures and assertions now derive Note (non-blocking): the PR currently reports a merge conflict with Reviewed fa0cf4f |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
develop is red: #301 bumped
WORKER_RUNTIME_SCHEMA_VERSION2→3, but its merge CI path-filtered away theapps/webtest suite, so seven stale test expectations surfaced only when later merges (#291) touchedapps/weband made CI actually run them.No runtime bug — #301 never touched the provisioning currency logic; verified against its diff. This is test-only:
WORKER_RUNTIME_SCHEMA_VERSION/WORKER_RUNTIME_SCHEMA_TAGinstead of hardcoded2/-r2, so future bumps don't break themimportOriginal, so fixtures and assertions exercise the real templateRef derivations instead of hand-rolled suffix-less stringsTesting
apps/websuite: 281 files / 1969 tests green (was 7 red on develop)check-types:fast, prettier cleanUnblocks develop and #305.
🤖 Generated with Claude Code