Skip to content

[Fix] Develop CI fails on web worker template schema tests#304

Merged
mrubens merged 1 commit into
developfrom
fix/web-worker-template-r3-tests-0zblvd955t2ym
Jul 13, 2026
Merged

[Fix] Develop CI fails on web worker template schema tests#304
mrubens merged 1 commit into
developfrom
fix/web-worker-template-r3-tests-0zblvd955t2ym

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Created by Roomote. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

Related issue

No linked GitHub issue. This follows red develop CI after the hosted worker runtime schema bump in #301.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Web unit tests that assert hosted worker template/snapshot refs and current runtime-schema fixtures now match production derivation (-r3 / schema version 3). Stale -r2 expectations and schema-version 2 fixtures used as “current”/in-flight cases caused false failures after the #301 schema bump.

How it was tested

  • Reproduced the CI failure signature locally: 7 failing tests across compute/index.test.ts, setup-new/index.test.ts, and compute-provisioning.test.ts.
  • After the fixture updates, re-ran those three files: 71/71 passed.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

@roomote-roomote

roomote-roomote Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Test-only fixture alignment. The -r3 template/snapshot expectations and runtimeSchemaVersion: 3 "current" fixtures match production derivation (WORKER_RUNTIME_SCHEMA_VERSION = 3, WORKER_RUNTIME_SCHEMA_TAG = r3), and the deliberately stale/superseded -r2 / version 2 fixtures are correctly left untouched. Re-ran the three files locally: 71/71 passed.

Reviewed 5d1487f

@mrubens
mrubens marked this pull request as ready for review July 13, 2026 23:37
@mrubens
mrubens merged commit 6bdd295 into develop Jul 13, 2026
18 checks passed
@mrubens
mrubens deleted the fix/web-worker-template-r3-tests-0zblvd955t2ym branch July 13, 2026 23:37
brunobergher pushed a commit that referenced this pull request Jul 14, 2026
Co-authored-by: Roomote <roomote@roomote.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants