Skip to content

[Fix] PR review notifications offer fixes for handled feedback - #1263

Merged
daniel-lxs merged 1 commit into
developfrom
fix/pr-review-notification-fidelity-2vxogv0k12uyq
Aug 13, 2026
Merged

[Fix] PR review notifications offer fixes for handled feedback#1263
daniel-lxs merged 1 commit into
developfrom
fix/pr-review-notification-fidelity-2vxogv0k12uyq

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. View the task or mention @roomote-roomote for follow-up asks.

Depends on #1264. This is the final PR in the review-notification stack.

What changed

  • Preserve bounded, untrusted review bodies, provider comment IDs, reply relationships, and stable bot identity.
  • Treat edited top-level review comments as distinct content revisions while exact webhook replays remain deduplicated.
  • Filter resolved/outdated inline events and submitted reviews for an older PR head before helper triage.
  • Separate notification value from actionability.
  • Permit an automated-review action offer only when live provider state proves an open matching thread, failed CI, or merge conflict.
  • Preserve deterministic fallback offers for human requested changes and live failures when helper output is incomplete.

Why

Discarding actual feedback and per-comment live state makes handled and actionable review activity look alike. A model-only decision can therefore offer work that no longer exists or miss work that provably does.

Proof

The local matrix covers edited content, bounded/untrusted prompt data, resolved threads, outdated threads, open matching threads, stale-head reviews, clean automated summaries, requested changes, failed CI, and conflicts. Resolved/outdated/stale events are removed before inference. Automated summary text alone cannot create an action offer. The stacked head passes 259 focused tests, repository-wide oxlint, 27-package fast typecheck, and knip.

@roomote-community

roomote-community Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

  • packages/sdk/src/server/lib/task-runs/pr-review-notification-delivery.ts:577 Clean No code issues found. self-reviews can still receive a resolve offer.
  • apps/api/src/handlers/github/notifyPrReviewActivity.ts:39 Review-body aggregation is unbounded and can exceed the triage model's input limit.
  • packages/sdk/src/server/lib/pull-requests/source-control-pull-request-reads.ts:1071 The open-thread action signal is incomplete when a PR has more than 100 review threads or a thread has more than 50 comments.
  • apps/api/src/handlers/github/notifyPrReviewActivity.ts:100 Edited comments without updated_at reuse the creation-time deduplication key, so later edits can be dropped.
  • apps/api/src/handlers/github/notifyPrReviewActivity.ts:58 Timestamp-less summary lifecycle events use per-delivery revisions, preventing terminal summaries from closing their open review cycle.
  • packages/sdk/src/server/lib/task-runs/pr-review-notification-delivery.ts:904 Resolved or outdated feedback from a submitted changes_requested review still forces a resolve offer.

Reviewed ba11890

Comment thread packages/sdk/src/server/lib/task-runs/pr-review-notification-delivery.ts Outdated
@roomote-roomote roomote-roomote Bot changed the title [Fix] PR review notifications offer fixes for non-actionable activity [Fix] PR review notifications offer fixes for handled feedback Aug 12, 2026
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch from cc726bf to 90092c5 Compare August 13, 2026 07:06
@daniel-lxs
daniel-lxs changed the base branch from develop to fix/external-review-notification-coalescing-3hlota14wdtid August 13, 2026 07:06
@daniel-lxs
daniel-lxs marked this pull request as ready for review August 13, 2026 07:07
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch from 90092c5 to c011e3b Compare August 13, 2026 07:21
@daniel-lxs
daniel-lxs force-pushed the fix/external-review-notification-coalescing-3hlota14wdtid branch 2 times, most recently from 3d0a5e3 to b9fef91 Compare August 13, 2026 18:52
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch from c011e3b to 059987a Compare August 13, 2026 18:53
Comment thread apps/api/src/handlers/github/notifyPrReviewActivity.ts
@daniel-lxs
daniel-lxs force-pushed the fix/external-review-notification-coalescing-3hlota14wdtid branch from b9fef91 to 3150b79 Compare August 13, 2026 18:58
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch 2 times, most recently from 7e99492 to e23916c Compare August 13, 2026 19:05
@daniel-lxs
daniel-lxs force-pushed the fix/external-review-notification-coalescing-3hlota14wdtid branch from 3150b79 to 2b244d9 Compare August 13, 2026 19:08
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch from e23916c to 41b5ba9 Compare August 13, 2026 19:08
@daniel-lxs
daniel-lxs force-pushed the fix/external-review-notification-coalescing-3hlota14wdtid branch from 2b244d9 to b8163f6 Compare August 13, 2026 19:15
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch from 41b5ba9 to 4cff379 Compare August 13, 2026 19:15
@daniel-lxs
daniel-lxs force-pushed the fix/external-review-notification-coalescing-3hlota14wdtid branch from b8163f6 to bf6e29a Compare August 13, 2026 19:17
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch 2 times, most recently from 390889e to 192fef6 Compare August 13, 2026 19:33
@daniel-lxs
daniel-lxs force-pushed the fix/external-review-notification-coalescing-3hlota14wdtid branch from bf6e29a to 13ff27a Compare August 13, 2026 19:33
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch from 192fef6 to 26a412b Compare August 13, 2026 19:42
@daniel-lxs
daniel-lxs force-pushed the fix/external-review-notification-coalescing-3hlota14wdtid branch from 13ff27a to 4341671 Compare August 13, 2026 19:42
Comment thread apps/api/src/handlers/github/notifyPrReviewActivity.ts Outdated
@daniel-lxs
daniel-lxs force-pushed the fix/external-review-notification-coalescing-3hlota14wdtid branch from 4341671 to a222f09 Compare August 13, 2026 19:48
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch 2 times, most recently from b9d51bd to 71f99ac Compare August 13, 2026 19:53
@daniel-lxs
daniel-lxs force-pushed the fix/external-review-notification-coalescing-3hlota14wdtid branch from a222f09 to ef6b6a7 Compare August 13, 2026 19:55
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch from 71f99ac to 6055a4e Compare August 13, 2026 19:55
Base automatically changed from fix/external-review-notification-coalescing-3hlota14wdtid to develop August 13, 2026 19:57
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch 2 times, most recently from fe573b4 to f241857 Compare August 13, 2026 20:02
@daniel-lxs
daniel-lxs force-pushed the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch from f241857 to ba11890 Compare August 13, 2026 20:14
@daniel-lxs
daniel-lxs merged commit 16cb45d into develop Aug 13, 2026
18 checks passed
@daniel-lxs
daniel-lxs deleted the fix/pr-review-notification-fidelity-2vxogv0k12uyq branch August 13, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant