fix: suppress handled PR review action offers

Author: daniel-lxs

apps/api/src/handlers/github/__tests__/index.test.ts

@@ -216,9 +216,12 @@ github.post('/', async (c) => {
 
     webhooks.on('issue_comment.edited', async ({ id, name, payload }) => {
       if (payload.issue.pull_request) {
-        // Roomote review summaries are posted as "review in progress" and
-        // patched with the results, so the terminal content arrives here.
-        await queuePrReviewSummaryNotification(payload);
+        // Roomote summaries and external top-level review comments can both
+        // be edited from placeholder content into their final result.
+        await Promise.all([
+          queuePrReviewActivityNotification(payload),
+          queuePrReviewSummaryNotification(payload),
+        ]);
       }
 
       return recordWebhook(

apps/api/src/handlers/github/__tests__/notifyPrReviewActivity.test.ts

@@ -23,6 +23,7 @@ import type {
 
 type PrReviewActivityWebhookPayload =
   | WebhookIssueCommentCreated
+  | WebhookIssueCommentEdited
   | WebhookPullRequestReviewSubmitted
   | WebhookPullRequestCommentCreated;
 
@@ -31,6 +32,12 @@ type PrReviewSummaryWebhookPayload =
   | WebhookIssueCommentEdited;
 
 const MAX_SUMMARY_LENGTH = 300;
+const MAX_REVIEW_BODY_LENGTH = 10_000;
+
+function getReviewBody(value: string | null | undefined): string | undefined {
+  const body = value?.trim();
+  return body ? body.slice(0, MAX_REVIEW_BODY_LENGTH) : undefined;
+}
 
 function getAutomatedAuthorMetadata(
   user: { id?: number; type?: string } | null | undefined,
@@ -72,6 +79,7 @@ export function buildPrReviewActivityNotificationInput(
 
     const comment = eventPayload.comment;
     const authorLogin = comment.user?.login;
+    const body = getReviewBody(comment.body);
 
     if (
       !authorLogin ||
@@ -89,11 +97,12 @@ export function buildPrReviewActivityNotificationInput(
       sourceControlProvider: 'github',
       event: {
         kind: 'issue_comment',
-        providerEventId: `github-issue-comment:${comment.id}`,
+        providerEventId: `github-issue-comment:${comment.id}:${comment.updated_at ?? comment.created_at}`,
         authorLogin,
         ...getAutomatedAuthorMetadata(comment.user),
+        ...(body ? { body } : {}),
         ...(comment.html_url ? { url: comment.html_url } : {}),
-        observedAt: getObservedAt(comment.created_at),
+        observedAt: getObservedAt(comment.updated_at ?? comment.created_at),
       },
     };
   }
@@ -108,6 +117,7 @@ export function buildPrReviewActivityNotificationInput(
   if ('review' in eventPayload) {
     const review = eventPayload.review;
     const authorLogin = review.user?.login;
+    const body = getReviewBody(review.body);
 
     if (!authorLogin) {
       return null;
@@ -128,6 +138,7 @@ export function buildPrReviewActivityNotificationInput(
         providerEventId: `github-review:${review.id}`,
         authorLogin,
         ...getAutomatedAuthorMetadata(review.user),
+        ...(body ? { body } : {}),
         ...(review.commit_id ? { reviewHeadSha: review.commit_id } : {}),
         batchId: `github-review:${review.id}`,
         reviewState: review.state,
@@ -144,6 +155,7 @@ export function buildPrReviewActivityNotificationInput(
 
   const comment = eventPayload.comment;
   const authorLogin = comment.user?.login;
+  const body = getReviewBody(comment.body);
 
   if (!authorLogin) {
     return null;
@@ -167,6 +179,10 @@ export function buildPrReviewActivityNotificationInput(
       providerEventId: `github-review-comment:${comment.id}`,
       authorLogin,
       ...getAutomatedAuthorMetadata(comment.user),
+      ...(comment.in_reply_to_id
+        ? { inReplyToId: String(comment.in_reply_to_id) }
+        : {}),
+      ...(body ? { body } : {}),
       ...(comment.commit_id ? { reviewHeadSha: comment.commit_id } : {}),
       ...(comment.pull_request_review_id
         ? { batchId: `github-review:${comment.pull_request_review_id}` }