DEV: Fix Lint/DuplicateMethods (discourse#24746)

RickyC0626-forks · Dec 6, 2023 · 138bf48 · 138bf48
1 parent 4280c01
commit 138bf48
Show file tree

Hide file tree

Showing 16 changed files with 5 additions and 64 deletions.
diff --git a/app/models/about.rb b/app/models/about.rb
@@ -18,8 +18,6 @@ def initialize(category_id, moderators)
   include ActiveModel::Serialization
   include StatsCacheable
 
-  attr_accessor :moderators, :admins
-
   def self.stats_cache_key
     "about-stats"
   end

diff --git a/app/models/email_style.rb b/app/models/email_style.rb
@@ -3,8 +3,6 @@
 class EmailStyle
   include ActiveModel::Serialization
 
-  attr_accessor :html, :css, :default_html, :default_css
-
   def id
     "email-style"
   end

diff --git a/app/models/report.rb b/app/models/report.rb
@@ -76,8 +76,6 @@ class Report
                 :icon,
                 :modes,
                 :prev_data,
-                :prev_start_date,
-                :prev_end_date,
                 :dates_filtering,
                 :error,
                 :primary_color,

diff --git a/app/models/search_log.rb b/app/models/search_log.rb
@@ -5,8 +5,6 @@ class SearchLog < ActiveRecord::Base
 
   belongs_to :user
 
-  attr_reader :ctr
-
   def ctr
     return 0 if click_through == 0 || searches == 0
 

diff --git a/app/models/tag_group.rb b/app/models/tag_group.rb
@@ -22,7 +22,7 @@ class TagGroup < ActiveRecord::Base
 
   after_commit { DiscourseTagging.clear_cache! }
 
-  attr_accessor :permissions
+  attr_reader :permissions
 
   def tag_names=(tag_names_arg)
     DiscourseTagging.add_or_create_tags_by_name(self, tag_names_arg, unlimited: true)

diff --git a/app/models/topic_list.rb b/app/models/topic_list.rb
@@ -40,7 +40,6 @@ def self.preload_user_ids(topics, user_ids, object)
     :filter,
     :for_period,
     :per_page,
-    :top_tags,
     :current_user,
     :tags,
     :shared_drafts,

diff --git a/app/models/trust_level3_requirements.rb b/app/models/trust_level3_requirements.rb
@@ -26,33 +26,6 @@ def total
   LOW_WATER_MARK = 0.9
   FORGIVENESS_PERIOD = 6.months
 
-  attr_accessor :days_visited,
-                :min_days_visited,
-                :num_topics_replied_to,
-                :min_topics_replied_to,
-                :topics_viewed,
-                :min_topics_viewed,
-                :posts_read,
-                :min_posts_read,
-                :topics_viewed_all_time,
-                :min_topics_viewed_all_time,
-                :posts_read_all_time,
-                :min_posts_read_all_time,
-                :num_flagged_posts,
-                :max_flagged_posts,
-                :num_likes_given,
-                :min_likes_given,
-                :num_likes_received,
-                :min_likes_received,
-                :num_likes_received,
-                :min_likes_received,
-                :num_likes_received_days,
-                :min_likes_received_days,
-                :num_likes_received_users,
-                :min_likes_received_users,
-                :trust_level_locked,
-                :on_grace_period
-
   def initialize(user)
     @user = user
   end

diff --git a/app/serializers/user_post_bookmark_serializer.rb b/app/serializers/user_post_bookmark_serializer.rb
@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
 class UserPostBookmarkSerializer < UserPostTopicBookmarkBaseSerializer
-  attr_reader :post_id
-
   def post_id
     post.id
   end

diff --git a/lib/has_errors.rb b/lib/has_errors.rb
@@ -3,7 +3,6 @@
 # Helper functions for dealing with errors and objects that have
 # child objects with errors
 module HasErrors
-  attr_reader :errors
   attr_accessor :forbidden, :not_found, :conflict
 
   def errors

diff --git a/lib/import_export/base_exporter.rb b/lib/import_export/base_exporter.rb
@@ -2,7 +2,7 @@
 
 module ImportExport
   class BaseExporter
-    attr_reader :export_data, :categories
+    attr_reader :export_data
 
     CATEGORY_ATTRS = %i[
       id

diff --git a/plugins/chat/app/serializers/chat/user_message_bookmark_serializer.rb b/plugins/chat/app/serializers/chat/user_message_bookmark_serializer.rb
@@ -2,8 +2,6 @@
 
 module Chat
   class UserMessageBookmarkSerializer < UserBookmarkBaseSerializer
-    attr_reader :chat_message
-
     def title
       fancy_title
     end

diff --git a/plugins/chat/spec/system/page_objects/chat/components/messages.rb b/plugins/chat/spec/system/page_objects/chat/components/messages.rb
@@ -16,10 +16,6 @@ def component
           page.find(context)
         end
 
-        def flag(message)
-          find(message).secondary_action("flag")
-        end
-
         def copy_link(message)
           find(message).secondary_action("copyLink")
         end

diff --git a/plugins/chat/spec/system/page_objects/chat/components/thread_list.rb b/plugins/chat/spec/system/page_objects/chat/components/thread_list.rb
@@ -43,10 +43,6 @@ def last_reply_datetime_selector(last_reply)
           ".chat-thread-list-item__last-reply-timestamp .relative-date[data-time='#{(last_reply.created_at.iso8601.to_time.to_f * 1000).to_i}']"
         end
 
-        def has_no_unread_item?(id)
-          component.has_no_css?(item_by_id_selector(id) + ".-is-unread")
-        end
-
         def has_unread_item?(id, count: nil)
           if count.nil?
             component.has_css?(item_by_id_selector(id) + ".-is-unread")

diff --git a/plugins/chat/spec/system/page_objects/sidebar/sidebar.rb b/plugins/chat/spec/system/page_objects/sidebar/sidebar.rb
@@ -14,10 +14,6 @@ def channels_section
         find(PUBLIC_CHANNELS_SECTION_SELECTOR)
       end
 
-      def channels_section
-        find(PUBLIC_CHANNELS_SECTION_SELECTOR)
-      end
-
       def dms_section
         find(DM_CHANNELS_SECTION_SELECTOR)
       end

diff --git a/spec/support/fake_logger.rb b/spec/support/fake_logger.rb
@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
 class FakeLogger
-  attr_reader :debug, :infos, :warnings, :errors, :fatals
+  attr_reader :debugs, :infos, :warnings, :errors, :fatals
   attr_accessor :level
 
   def initialize
-    @debug = []
+    @debugs = []
     @infos = []
     @warnings = []
     @errors = []
@@ -14,7 +14,7 @@ def initialize
   end
 
   def debug(message)
-    @debug << message
+    @debugs << message
   end
 
   def debug?

diff --git a/spec/system/page_objects/modals/sidebar_edit_categories.rb b/spec/system/page_objects/modals/sidebar_edit_categories.rb
@@ -39,12 +39,6 @@ def has_categories?(categories)
         expect(categories.map(&:text)).to eq(category_names)
       end
 
-      def has_checkbox?(category, disabled: false)
-        has_selector?(
-          ".sidebar-categories-form .sidebar-categories-form__category-row[data-category-id='#{category.id}'] .sidebar-categories-form__input#{disabled ? "[disabled]" : ""}",
-        )
-      end
-
       def toggle_category_checkbox(category)
         find(
           ".sidebar-categories-form .sidebar-categories-form__category-row[data-category-id='#{category.id}'] .sidebar-categories-form__input",
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,8 +5,6 @@ class SearchLog < ActiveRecord::Base @@
       belongs_to :user
-      attr_reader :ctr
       def ctr
         return 0 if click_through == 0 || searches == 0
@@ Expand Down @@