DEV: Fix Lint/ShadowedArgument (discourse#24733)

app/jobs/scheduled/periodical_updates.rb

@@ -14,7 +14,7 @@ def self.should_update_long_topics?
       (@call_count % 24) == 1
     end
 
-    def execute(args = nil)
+    def execute(_ = nil)
       # Feature topics in categories
       CategoryFeaturedTopic.feature_topics(batched: true)
 

lib/compression/pipeline.rb

@@ -12,10 +12,9 @@ def extension
 
     def compress(path, target_name)
       current_target = target_name
-      @strategies.reduce("") do |compressed_path, strategy|
+      @strategies.reduce(nil) do |_, strategy|
         compressed_path = strategy.compress(path, current_target)
         current_target = compressed_path.split("/").last
-
         compressed_path
       end
     end

lib/onebox/engine/standard_embed.rb

@@ -160,7 +160,7 @@ def get_json_ld
       end
 
       def set_from_normalizer_data(normalizer)
-        normalizer.data.each do |k, v|
+        normalizer.data.each do |k, _|
           v = normalizer.send(k)
           @raw[k] ||= v unless v.nil?
         end

plugins/chat/lib/chat/user_notifications_extension.rb

@@ -2,7 +2,7 @@
 
 module Chat
   module UserNotificationsExtension
-    def chat_summary(user, opts)
+    def chat_summary(user, _ = nil)
       guardian = Guardian.new(user)
       return unless guardian.can_chat?
 

spec/models/user_spec.rb

@@ -32,7 +32,7 @@ def user_error_message(*keys)
     describe "default sidebar section links" do
       fab!(:category)
 
-      fab!(:secured_category) do |category|
+      fab!(:secured_category) do
         category = Fabricate(:category)
         category.permissions = { "staff" => :full }
         category.save!

spec/requests/invites_controller_spec.rb

@@ -300,7 +300,7 @@
       context "when topic is private" do
         fab!(:group)
 
-        fab!(:secured_category) do |category|
+        fab!(:secured_category) do
           category = Fabricate(:category)
           category.permissions = { group.name => :full }
           category.save!