Skip to content

fix(web): remove extra bottom gap on Files-changed tab #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dastratakos merged 1 commit into from
May 4, 2026
+1 −1
Merged

fix(web): remove extra bottom gap on Files-changed tab #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web/src/routes/pull-request-layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export function PullRequestLayout({ runId }: { runId: string }) {

return (
<div className="flex flex-1 flex-col" style={layoutStyle}>
<div className="flex-1 px-6 pt-6 pb-16 lg:px-8">
<div className="flex-1 px-6 pt-6 lg:px-8">

@cursor cursor Bot May 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chapters tab loses all bottom padding unintentionally

Medium Severity

Removing pb-16 from this wrapper fixes the Files tab but also removes all bottom padding from the Chapters tab. The PR justification that SidebarLayout's py-4 provides sufficient margin only applies to the Files tab — the Chapters tab (ChaptersIndexPage / ChaptersList) renders directly into the Outlet without SidebarLayout, so its last chapter entry now sits flush against the container bottom with no visual breathing room.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0ec6552. Configure here.

<header className="mb-4 space-y-1">
<SectionLabel>Run</SectionLabel>
<p className="break-all font-mono text-foreground/80 text-xs">{data?.run.id ?? runId}</p>
Expand Down
Loading