fix(web): remove extra bottom gap on Files-changed tab#22
Conversation
The 64px pb-16 on the PR layout wrapper let users scroll past the last file into empty space. The 16px from SidebarLayout's main py-4 already provides a small visual margin at the bottom.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0ec6552. Configure here.
| return ( | ||
| <div className="flex flex-1 flex-col" style={layoutStyle}> | ||
| <div className="flex-1 px-6 pt-6 pb-16 lg:px-8"> | ||
| <div className="flex-1 px-6 pt-6 lg:px-8"> |
There was a problem hiding this comment.
Chapters tab loses all bottom padding unintentionally
Medium Severity
Removing pb-16 from this wrapper fixes the Files tab but also removes all bottom padding from the Chapters tab. The PR justification that SidebarLayout's py-4 provides sufficient margin only applies to the Files tab — the Chapters tab (ChaptersIndexPage / ChaptersList) renders directly into the Outlet without SidebarLayout, so its last chapter entry now sits flush against the container bottom with no visual breathing room.
Reviewed by Cursor Bugbot for commit 0ec6552. Configure here.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
1 participant
Summary
The PR layout wrapper had
pb-16(64px) of bottom padding, which let users scroll past the last file into empty space on the Files-changed tab. The 16px fromSidebarLayout's<main>py-4already provides a small visual margin at the bottom, so the document now ends just below the last file.Changes
pb-16from the inner content wrapper inpackages/web/src/routes/pull-request-layout.tsx.Testing
pnpm typecheck,pnpm lint,pnpm test(124 tests) all pass.