Repository navigation
Stash tabs: withdraw, deposit and click(item) - #65
Merged
Merged
Conversation
ResurrectedTrader
added this pull request to stack #78
October 6, 2026 23:12
ResurrectedTrader
force-pushed
the
stash-withdraw-deposit
branch
from
October 6, 2026 23:14
ef700b2 to
b0e6e14
Compare
ResurrectedTrader
force-pushed
the
stash-withdraw-deposit
branch
from
October 7, 2026 07:03
b0e6e14 to
b0d667a
Compare
An advanced stash tab holds one stack per item class, and items move on and off it only through dedicated actions, never through grid placement. - Contract: StashTab::Withdraw(item, count, target) and Deposit(item), with a StashWithdrawTarget enum (cursor, inventory, cube, belt). - 1.14d: a plain grid tab has one withdraw, a count of 1 to the cursor (ClickItem on an item of the tab with the cursor empty); any other Withdraw and every Deposit return false. - JS: tab.withdraw(item, count = 1, target = StashWithdrawTarget.cursor), tab.deposit(item), and tab.click(item), which clicks the cell an item on this tab sits on (false for an item on another tab); the global StashWithdrawTarget constants. - StashTabType.chronicle is no longer exposed to scripts: no tab ever reports it. A new `/// @internal` enumerator marker keeps it out of extract_api.py's option sets, the API docs and the d.ts. - unit.itemcount documents that an item on an advanced stash tab reports its stack size. docs/stash_tabs.md and CLAUDE.md follow. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ResurrectedTrader
force-pushed
the
stash-withdraw-deposit
branch
from
October 7, 2026 07:23
b0d667a to
2da8893
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stash tab withdraw / deposit, for tabs that hold one stack per item class (advanced stash tabs):
StashTab::Withdraw(item, count, target)/Deposit(item)and aStashWithdrawTargetenum (cursor, inventory, cube, belt).ClickItemwith the cursor empty); everything else returns false.tab.withdraw(item, count = 1, target = StashWithdrawTarget.cursor),tab.deposit(item),tab.click(item)(clicks the cell the item sits on; false for an item on another tab), and theStashWithdrawTargetconstants.StashTabType.chronicleis no longer exposed to scripts (no tab reports it). A new/// @internalenumerator marker keeps a value out ofextract_api.py's option sets, the API docs and the d.ts.unit.itemcountdocuments the stack-size reading on an advanced stash tab.docs/stash_tabs.md and CLAUDE.md follow.
Stack
Stacked on #64 (this PR's base branch); it depends on that change and the ones below it. Merge in order; once the base merges, this PR is retargeted to
main(automatically when the merged branch is deleted).Verification
build.ps1 Release(Win32, the 1.14d DLL): buildsbuild.ps1 test: 169/169 passbuild.ps1 check-format: cleanscripts/gen_enum_names.py --check: up to date🤖 Generated with Claude Code