Repository navigation
feat(lod114d): PlugY multi-page stash through the StashTab contract #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
aa5f456
feat(lod114d): expose PlugY's multi-page stash through the StashTab c…
ResurrectedTrader 59f5633
chore: drop the one-off PlugY patch-site overlap audit script
ResurrectedTrader e1551a0
refactor(plugy): finalise the no-PlugY verdict, split IsActive from H…
ResurrectedTrader d4e59d9
refactor(plugy): finish moving the mirror logic onto the PlugY structs
ResurrectedTrader bf23d3f
refactor(plugy): fold the item-walk helpers into PYPlayerData::ForEac…
ResurrectedTrader 9ef5dc5
refactor(plugy): read the module version through utils, inline the on…
ResurrectedTrader f5b1ef8
refactor(plugy): generic PollUntil and IsInsideModule / ReadValue in …
ResurrectedTrader 29a05ae
fix(plugy): plan page switches without PlugY's first-page command
ResurrectedTrader 9578e69
fix(plugy): lock the location getter, wait for the specific ack id, f…
ResurrectedTrader a51860f
refactor(stash): one StashTab::MoveGold(mode, amount) instead of Depo…
ResurrectedTrader 7c02171
docs(stash): drop the narrating comment on the location getter's lock
ResurrectedTrader 50b7087
fix(plugy): make the post-click page restore best-effort and quiet
ResurrectedTrader File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have IsActive && HasStashTAbs check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in d4e59d9: the call site checks plugy::IsActive() && plugy::HasStashTabs() first, and IsParkedItem is now only the signature test.