Skip to content

Stash container reports vanilla 6x8 dimensions with PlugY, so items are captured outside the reported bounds #10

Closed

Description

@sam-coodu

Summary

With PlugY installed, the captured stash container is reported with vanilla 6x8 dimensions, but items are captured at coordinates outside those bounds. Any consumer that trusts width/height (e.g. D2BotNG's Characters view) then renders those items outside the grid.

PlugY's ActiveBigStash extends the personal stash beyond vanilla, and ActiveMultiPageStash adds further pages.

Evidence

From data/ng/captures.db, single-player character, PlugY 14.03 active:

-- container
profile     name     label       page  width  height
SCL-NECRO   stash    Personal    0     6      8

-- items in that container with y >= height
profile     code   x   y
SCL-NECRO   r09    0   8
SCL-NECRO   r10    0   9

height is reported as 8, yet items sit at y = 8 and y = 9. The items themselves are correct - the game and the bot scripts use them fine, and kolbot's own Storage override treats a PlugY stash as 10 rows (libs/SoloPlay/Core/StorageOverrides.js: this.StashY = ... Settings.plugyMode ? 10 : 8).

Two related observations:

  1. Dimensions do not reflect PlugY's expansion. The stash appears to be reported at the vanilla size regardless.
  2. Additional PlugY stash pages are not captured. Only page = 0 is ever present, so items on pages 2+ do not appear at all.

Expected

The reported width/height should describe the actual usable stash, so that 0 <= x < width and 0 <= y < height holds for every captured item. Ideally each PlugY stash page would be captured as its own container/page too.

Notes for consumers

Even with this fixed, it may be worth clients sizing the grid to max(declared, max_item_extent) defensively, so an unexpected mod can't push items out of the visible area.

Environment

  • d2bsng v2.1.1, injected into Diablo II LoD 1.14d, single player
  • PlugY 14.03 with ActiveBigStash=1, ActiveMultiPageStash=1, NbPagesPerIndex=10, ActiveSharedStash=0
  • Scripts: kolbot + kolbot-SoloPlay (plugyMode: true)
  • Manager: D2BotNG v0.0.47 (where the visual symptom shows, in Characters -> Inventory -> Stash)

Activity

  1. ResurrectedTrader commented on Sep 8, 2026

    @ResurrectedTrader
    Owner

    This should be fixed for containers. Stash pages are not easily accessible unless I hardcode pointer addresses etc.
    Not sure how to approach that, so I'll leave this open for now.

  2. ResurrectedTrader commented on Sep 13, 2026

    @ResurrectedTrader
    Owner

    Fixed by #19
    Will cut a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions