-
Notifications
You must be signed in to change notification settings - Fork 1k
#1523 progress: adds option for dplyr-inspired column class summary with printing #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1523 progress: adds option for dplyr-inspired column class summary with printing #1529
Conversation
Great! I think Like points 1 and 2. I think it's self-evident on 3, but I don't have a preference either. |
Seems excellent. But build fails on that test.. If you're not already aware, use Another error from Examples. |
@arunsrinivasan I used |
@MichaelChirico when you fix and rebase, ping me, I'll merge. 👍 |
@arunsrinivasan |
Did you pull to get to the latest commit? I guess it's because of the last two issues I closed. |
attempting test fix again gave up on second test fixing error in .Rd
@arunsrinivasan finally got it to pass muster. Did away with one of the tests that was being stubborn; the remaining test gets the point across I think. |
@MichaelChirico looks great. For the future, it'd be nice to have a PR for a single issue.. Will merge this, and take a look at the test after. |
#1523 progress: adds option for dplyr-inspired column class summary with printing
@arunsrinivasan it's been a while, sadly can't remember which test it was... about single PRs, I'm getting conflicting messages from you... See comments in #1523:
Could you clarify? Happy to follow whichever you prefer. |
@MichaelChirico, Sure. I mean, separate PRs == 1 PR for 1 issue. The consolidation of all other print related issues is for us to easily find them in one place. They do not represent one big issue. Is that the confusion? |
@arunsrinivasan hmm still not 100% sure I'm with you. How about this: For the remaining 8 bullet points of #1523, should I file 8 PRs, or just 1? |
8 bullet points = 8 separate issues = 8 separate PRs. They are consolidated there for convenience. #1523 does not represent one giant issue. |
@arunsrinivasan about PRs, basically with you, but the 8 points there represent only 6 issues (since points 5-7 address different parts of #645). Should I submit one PR for 5-7, or three? |
#645 is from R-Forge where multiple issues got filed together too often. Those points seem to be 4 different enhancements AFAICT. It has very less to do with how issues are filed. Separate commits help debug the issue later / fix them if there's a bug/regression and not having to search as to which code part corresponded to which fix. |
@MichaelChirico I've already taken care of it.. pushing a commit with minor changes. |
Tasks 1 and 8 of #1523 (will incrementally fill out the .Rd as the other features are added).
Judgment calls (not married to any of them, so happy to change):
class
es to support, and their abbreviation:dplyr
. This was basically to match the existing formatting done tolist
columns."Classes:"
or something to that effect)