More progress towards #1523 - by group separation #1533
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempting test fix again gave up on second test fixing error in .Rd first pass at print-by option another pass obeying warning message, adding fill option fixed option missed long case attempting fix of long case closing in on finishing PR adding tests, tinkering fixing tests?
|
Sorry, I don't know what this is. Will revisit print methods later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arunsrinivasan this nests the previous PR since we didn't manage to iron out the kinks before you signed off yesterday. I'm not sure the protocol for serial PRs like this. Of course don't want to get too far ahead in case we need revisions but it seems #1529 is ready to merge.
A note about implementation:
It seems like from the feedback we're gotten in the FR & Frank's comment, people are mainly using this on sorted tables; I think the implementation on an unsorted table is a bit harder (and probably slower), so I left an error for trying to use this on unsorted tables.
The way to do it with an unsorted table is with
rle, but I decided it wasn't worth the effort of figuring out how to make that work; we'll see if it comes up again in a future FR.