Skip to content

Tests: Slightly improve the test suite and its documentation #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Tests: Slightly improve the test suite and its documentation #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a8bcdb
Tests: Run test suite against `crate/crate:nightly`
amotl Oct 6, 2022
11bda32
Tests: Add documentation how to invoke the test suite to the README
amotl Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,3 +646,11 @@ Data tests will create:

- `t_migration` table for test table migrations,
- `t_users` table for some dummy user data.

To invoke the test suite, run:
```shell
git clone https://github.com/RatkoR/laravel-crate.io
cd laravel-crate.io
composer install
Copy link
Owner

@RatkoR RatkoR Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add additional lines here:

composer install
# change $table->increment('id') to $table->integer('id') in DatabaseMigrationRepository
# set you DB conn properties
./run-tests.sh

or else run-tests.sh will probably not succeed.

Copy link
Contributor Author

@amotl amotl Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again,

on my machine, it just works excellently after cloning the repository, without any further ado.

composer install
./run-tests.sh
  1. There is no $table->increment('id') within tests/DataTests/Fixture/DatabaseMigrationRepository.php.
  2. I did not have to set any connection properties. The test suite flawlessly invoked a Docker instance of CrateDB for the duration of the test suite run, and apparently has been able to connect to it well.

With kind regards,
Andreas.

./run-tests.sh
```
3 changes: 2 additions & 1 deletion run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ echo '---- starting docker container crate ----'
docker run -d --name=crate01 \
-p 4201:4200 \
--env CRATE_HEAP_SIZE=2g \
crate -Cnetwork.host=_site_ \
crate/crate:nightly \
-Cnetwork.host=_site_ \
-Cdiscovery.type=single-node

echo '---- waiting for docker container crate to start ----'
Expand Down