Tests: Slightly improve the test suite and its documentation #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will reveal any eventual regressions early.
RatkoR
reviewed
Oct 7, 2022
| ```shell | ||
| git clone https://github.com/RatkoR/laravel-crate.io | ||
| cd laravel-crate.io | ||
| composer install |
Owner
There was a problem hiding this comment.
Can you add additional lines here:
composer install
# change $table->increment('id') to $table->integer('id') in DatabaseMigrationRepository
# set you DB conn properties
./run-tests.sh
or else run-tests.sh will probably not succeed.
Contributor
Author
There was a problem hiding this comment.
Hi again,
on my machine, it just works excellently after cloning the repository, without any further ado.
composer install
./run-tests.sh
- There is no
$table->increment('id')withintests/DataTests/Fixture/DatabaseMigrationRepository.php. - I did not have to set any connection properties. The test suite flawlessly invoked a Docker instance of CrateDB for the duration of the test suite run, and apparently has been able to connect to it well.
With kind regards,
Andreas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Ratko,
following up on #44, this patch adjusts some minor bits on the test suite. I hope you like them.
With kind regards,
Andreas.