Skip to content

Restore contract-proxied stake transfers #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UnArbosFive merged 2 commits into from
Sep 4, 2026
+11 −1
Merged

Restore contract-proxied stake transfers #3140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b92d4b
fix(runtime): allow transfer_stake through the contracts CallFilter
masterdubs Sep 3, 2026
30eb895
chore(runtime): bump spec version to 454
UnArbosFour Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
// `spec_version`, and `authoring_version` are the same between Wasm and native.
// This value is set to 100 to notify Polkadot-JS App (https://polkadot.js.org/apps) to use
// the compatible custom types.
spec_version: 453,
spec_version: 454,
impl_version: 1,
apis: RUNTIME_API_VERSIONS,
transaction_version: 1,
Expand Down Expand Up @@ -1407,6 +1407,16 @@ impl Contains<RuntimeCall> for ContractCallFilter {
fn contains(call: &RuntimeCall) -> bool {
match call {
RuntimeCall::Proxy(inner) => matches!(inner, pallet_proxy::Call::proxy { .. }),
// Since the proxy origin-filter inheritance fix (release 453), calls
// dispatched *inside* Proxy::proxy must also pass this filter. A
// contract holding an explicit user proxy delegation could
// previously execute transfer_stake on the user's behalf; allow
// that inner call again. Security is unchanged: the transfer still
// requires the user to have registered the contract as a proxy,
// and the inherited-filter fix keeps every other call blocked.
RuntimeCall::SubtensorModule(inner) => {
matches!(inner, pallet_subtensor::Call::transfer_stake { .. })
Comment on lines +1417 to +1418

@github-actions github-actions Bot Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] Add regression coverage for the expanded contract filter

This production regression fix changes a security-sensitive runtime allowlist but adds no test. Add focused coverage proving that the filter accepts transfer_stake and Proxy::proxy, rejects unrelated calls, and—preferably through dispatch—preserves rejection by NonTransfer, NonFungible, and over-limit SmallTransfer proxies.

}
_ => false,
}
}
Expand Down
Loading