feat: Send notification for user comment #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
orronai
commented
Oct 3, 2020
orronai
commented
- Moderator would receive replies from user
- The moderator would get only one message for user replies
- Added some unittests
- IMPORTANT: Moderator won't get messages between two different replies if he won't comment in the middle
- The checker of the solution will get notification for user comments replies - Added some unittests - IMPORTANT: If user comments before the solution has checked and the moderator didn't add comments - he won't see new comments - The moderator will get just one notification when user comment, after the moderator replies the comments
- The checker of the solution will get notification for user comments replies - Added some unittests - IMPORTANT: If user comments before the solution has checked and the moderator didn't add comments - he won't see new comments - The moderator will get just one notification when user comment, after the moderator replies the comments
- Now there will be ping pong notifications, untill someone stops commenting - Fixed a test - Compiled babel translations again
orronai
changed the title
yammesicka
reviewed
Oct 3, 2020
yammesicka
reviewed
Oct 3, 2020
- Fixed comments sorting check in order to get last comment
yammesicka
requested changes
Oct 3, 2020
- Now user can comment only after a solution has checked - Translated babel again
- Added a test to check that user can't comment before solution has checked
yammesicka
reviewed
Oct 4, 2020
yammesicka
requested changes
Oct 5, 2020
… send-notification-for-user-comment
- Fixed a test - IMPORTANT: User can't comment until exercise has been checked
… send-notification-for-user-comment
yammesicka
requested changes
Oct 7, 2020
- Fixed pull origin master conflicts
yammesicka
approved these changes
Oct 7, 2020
- Moved files limit sizes into config
yammesicka
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.