Skip to content

Allow students to comment/reply #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yammesicka opened this issue Sep 20, 2020 · 1 comment · Fixed by #193, #213, #218 or #225
Closed

Allow students to comment/reply #162

yammesicka opened this issue Sep 20, 2020 · 1 comment · Fixed by #193, #213, #218 or #225
Assignees
@orronai
Labels
Backend Enhancement New feature or request Hacktoberfest
Milestone
Better comments o...

Comments

@yammesicka
Copy link
Member

This feature must be configurable. Our users should be able to turn it on/off.
@orronai orronai self-assigned this Sep 29, 2020
This was linked to pull requests Oct 5, 2020
feat: Allow users to comment #193
Merged
feat: Send notification for user comment #213
Merged
feat: Colorize students comments #218
Merged
@yammesicka
Copy link
Member Author

yammesicka commented Oct 5, 2020 •
edited
Loading

Currently this feature allows XSS. We sould fix it before closing this ticket.

@orronai - this is a tough one, but can you please try and escape the users' comments?

@yammesicka yammesicka linked a pull request Oct 5, 2020 that will close this issue
Prevent user comments xss #225
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orronai orronai

Labels
Backend Enhancement New feature or request Hacktoberfest
Projects
None yet
Milestone
Better comments on exercises
2 participants
@yammesicka @orronai