-
Notifications
You must be signed in to change notification settings - Fork 52
feat:add waste heat from renewable fuel production and fuel cells #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…troduce fuel cell heat-losses
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition @amos-schledorn ! I went quickly through the changes (didn’t double-check the DEA data input).
For the entries based on model assumptions, could we keep a clearer separation from data-based inputs?
Regarding the energy balances affected by the new efficiency parameters: do we define either efficiency-to-heat or heat losses, and take the remainder as the difference?
Finally, I noticed the two 0.002 efficiencies in the methanolisation process—could you clarify these?
inputs/manual_input.csv
Outdated
methanation,heat-losses,2020,0.05,per unit,2017,Based on PyPSA-Eur assumptions (total efficiency of 0.95), | ||
fuel cell,heat-losses,2020,0.05,per unit,2017,Based on PyPSA-Eur assumptions (total efficiency of 0.95), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where in PyPSA-Eur do I find these assumptions? Shouldn't there be a clear distinction between the data from trusted sources and the parameters that are computed based on assumptions within the model?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Upon reconsideration, I've removed the heat losses - should be parameters in PyPSA-Eur, since the assumption is made there.
outputs/US/costs_2020.csv
Outdated
fuel cell,FOM,5.0,%/year,"Danish Energy Agency, inputs/technology_data_for_el_and_dh.xlsx",12 LT-PEMFC CHP: Fixed O&M,2015.0,, | ||
fuel cell,c_b,1.25,50oC/100oC,"Danish Energy Agency, inputs/technology_data_for_el_and_dh.xlsx",12 LT-PEMFC CHP: Cb coefficient,2015.0,, | ||
fuel cell,efficiency,0.5,per unit,"Danish Energy Agency, inputs/technology_data_for_el_and_dh.xlsx","12 LT-PEMFC CHP: Electricity efficiency, annual average",2015.0,, | ||
fuel cell,heat-losses,0.05,per unit,Based on PyPSA-Eur assumptions (total efficiency of 0.95),,2017.0,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't full understand the energy balance of the fuel cell:
Is it 1u of hydrogen --> 0.5u electricity + 0.05u heat losses + 0.45u high value heat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
outputs/US/costs_2020.csv
Outdated
methanolisation,efficiency,0.002,per unit,"Danish Energy Agency, inputs/data_sheets_for_renewable_fuels.xlsx",98 Methanol from hydrogen: District heating,2020.0,, | ||
methanolisation,efficiency-heat,0.002,per unit,"Danish Energy Agency, inputs/data_sheets_for_renewable_fuels.xlsx",98 Methanol from hydrogen: District heating,2020.0,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this value intentionally duplicated for both efficiencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, fixed that.
@cpschau Thanks for the review! I think I've addressed everything. Also checked values with the DEA data and updated the Haber-Bosch heat-efficiency accordingly. |
This PR adds efficiencies for excess heat recovery from renewable fuel production in district heating.
The considered processes are those for which PyPSA-Eur (Fischer-Tropsch, methanolisation, Haber-Bosch, methanation, electrolysis). Electrolysis is already covered:
https://github.com/PyPSA/pypsa-eur/blob/3df3152db900730df34eca86646f4a490940d48a/scripts/prepare_sector_network.py#L5291-L5417
Changes proposed in this Pull Request
heat-losses = 0.05
.Checklist
doc
.environment.yaml
(if applicable).doc/release_notes.rst
of the upcoming release is included.Edit
After review from @cpschau, I've removed the hard-coded heat losses for methanation and fuel cells.