FluidIngredient Refactor to support Create 6.0.7#239
FluidIngredient Refactor to support Create 6.0.7#239PssbleTrngle merged 1 commit intoPssbleTrngle:1.21.xfrom
Conversation
|
|
||
| fluids.forEach { fluidStack -> | ||
| val fluid = fluidStack.fluid | ||
| if (fluid is FlowingFluid) { |
There was a problem hiding this comment.
why the check for flowing fluid? Because it would recognize still/flowing water as separate things?
There was a problem hiding this comment.
Yes, the check if (fluid is FlowingFluid) is there because the still and flowing variants are separate fluid types, so only handling the flowing variant avoids treating 'still water' and 'flowing water' as distinct recipe ingredients.
Atleast thats what i understood from the docs.
There was a problem hiding this comment.
that's specifically what crashed me personally, something broke there and it said something about flowing fluid.
There was a problem hiding this comment.
Can you send me the full log? In my end the game launched normally, without errors and i was able to play it without any issue.
There was a problem hiding this comment.
cant, i use curseforge, so i wouldn't know to remove it once the mod updates.
There was a problem hiding this comment.
i can wait, i'll just backport create again.
There was a problem hiding this comment.
cant, i use curseforge, so i wouldn't know to remove it once the mod updates.
Enter to your modpack > 3 dots > Open folder > find the folder that is called "mods" > find the create slice and dice jar file. delete and replace with the temporary fix jar when i send it. Curseforge will recognise it but say its "modified" because its not installed by curseforge itself.
There was a problem hiding this comment.
the exact name of mod should be sliceanddice-forge-4.1.2.jar or sliceanddice-forge-4.1.2.jar.disabled
There was a problem hiding this comment.
i can just keep create unupdated until slice and dice updates.
|
@MegalithOfficial looks like it works fine, but from my testing the test for |
|
I'm going to test it further today. If something else occurs, I will let you know. |
|
thanks, that would be great, but for now it looks like it's working and I'll create a new release for it, thank you very much again for your effort |
Dependency Updates
neoforge_version,create_version,ponder_version, andregistrate_versioningradle.propertiesto the latest compatible versions.[[1]](diffhunk://#diff-3d103fc7c312a3e136f88e81cef592424b8af2464c468116545c4d22d6edcf19L7-R7) [[2]](diffhunk://#diff-3d103fc7c312a3e136f88e81cef592424b8af2464c468116545c4d22d6edcf19L19-R21)
Mixing Recipe Generation Refactor
Removed usage of Create’s deprecated
FluidIngredient.fromFluidStackinMixingRecipeGenerator.kt.Implemented NeoForge-compatible fluid handling:
FluidStackand validates the fluid as aFlowingFluid.builder.require(fluid, amount)for each valid fluid to register it in the recipe.Replaced the old
.withFluidIngredients(...)call with the new iterative builder approach.Added a new import for
net.minecraft.world.level.material.FlowingFluidand removed the outdatedcom.simibubi.create.foundation.fluid.FluidIngredientimport.