Skip to content

Change pcl gpu utils to an interface library #6364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −8
Open

Change pcl gpu utils to an interface library #6364

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8d5d5f
Change pcl gpu utils to a interface library, as it is header only and…
larshg Nov 7, 2025
6a5dd7d
Per copilot review.
larshg Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions cmake/pcl_targets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ endfunction()
function(PCL_CUDA_ADD_LIBRARY _name)
set(options)
set(oneValueArgs COMPONENT)
set(multiValueArgs SOURCES)
set(multiValueArgs SOURCES INCLUDES)
cmake_parse_arguments(ARGS "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})

if(ARGS_UNPARSED_ARGUMENTS)
Expand All @@ -263,8 +263,14 @@ function(PCL_CUDA_ADD_LIBRARY _name)

REMOVE_VTK_DEFINITIONS()
if(NOT ARGS_SOURCES)
add_library(${_name} INTERFACE)

if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.19)
add_library(${_name} INTERFACE ${ARGS_INCLUDES})

set_target_properties(${_name} PROPERTIES FOLDER "Libraries")
else()
add_library(${_name} INTERFACE)
endif()

target_include_directories(${_name} INTERFACE
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
$<INSTALL_INTERFACE:${INCLUDE_INSTALL_ROOT}>
Expand Down
4 changes: 1 addition & 3 deletions gpu/utils/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,12 @@ if(NOT build)
endif()

file(GLOB incs include/pcl/gpu/utils/*.h*)
file(GLOB srcs src/*.cpp src/*.cu src/*.h*)
file(GLOB dev_incs include/pcl/gpu/utils/device/*.h*)
source_group("Header Files\\device" FILES ${dev_incs})
source_group("Source Files" FILES ${srcs})

set(LIB_NAME "pcl_${SUBSYS_NAME}")
PCL_CUDA_ADD_LIBRARY(${LIB_NAME} COMPONENT ${SUBSYS_NAME} SOURCES ${dev_incs} ${incs} ${srcs})
target_link_libraries("${LIB_NAME}" pcl_common)
PCL_CUDA_ADD_LIBRARY(${LIB_NAME} COMPONENT ${SUBSYS_NAME} INCLUDES ${dev_incs} ${incs})

set(EXT_DEPS "")
#set(EXT_DEPS CUDA)
Expand Down
1 change: 0 additions & 1 deletion gpu/utils/src/empty.cu
View file
Open in desktop

This file was deleted.

Loading