Change pcl gpu utils to an interface library #6364
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… currently doesn't export any symbols causing gpu modules to not build.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR converts the pcl_gpu_utils library from a source-based library to a header-only INTERFACE library by removing the empty placeholder source file and updating the CMake configuration.
Key changes:
- Removes the empty
empty.cufile that was previously used to help CMake determine the link language - Updates
PCL_CUDA_ADD_LIBRARYfunction to support anINCLUDESparameter for header files - Modifies the library creation to use INTERFACE mode with conditional CMake 3.19+ support for associating header files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gpu/utils/src/empty.cu | Removes the empty placeholder CUDA file that is no longer needed |
| gpu/utils/CMakeLists.txt | Converts library to INTERFACE mode by removing source file globbing and using INCLUDES parameter instead |
| cmake/pcl_targets.cmake | Adds INCLUDES parameter support and CMake 3.19+ conditional logic for INTERFACE libraries with associated headers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
larshg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is header only and currently doesn't export any symbols causing gpu modules to fail to link pcl_gpu_utils, as it doesn't get created.