Skip to content

Check MJSON files for typos and errors #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thibaultzanini wants to merge 1 commit into
base: main
Choose a base branch
from
+55 −55
Open

Check MJSON files for typos and errors #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ance/party/profile/proficency-scale.mjson → ...nce/party/profile/proficiency-scale.mjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
]
},
"0199f8df-c7b4-7cdc-b68e-78042e80fa30": {
"prototype": "data/model/party/profiule/proficency-scale",
"prototype": "data/model/party/profile/proficiency-scale",
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"values": {
"name": {
"en": {
"US": "Four Level Proficency Scale"
"US": "Four Level Proficiency Scale"
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchant There is a typo Proficency is not a valid English word

},
"fr": {
"FR": ""
Expand Down
8 changes: 4 additions & 4 deletions data/model.mjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,11 @@
"PersonalStrengthAssessment": {
"object": "./model/party/profile/personal-strength-assessment.mjson"
},
"ProficencyScale": {
"object": "./model/party/profile/proficency-scale.mjson"
"ProficiencyScale": {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

"object": "./model/party/profile/proficiency-scale.mjson"
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object reference path has been updated to './model/party/profile/proficiency-scale.mjson', which correctly points to the renamed .mjson file. However, that .mjson file internally references './proficiency-scale.js' which doesn't exist (the file is still named 'proficency-scale.js'). This will cause module loading errors when this descriptor is used.

Suggested change
"object": "./model/party/profile/proficiency-scale.mjson"
"object": "./model/party/profile/proficency-scale.mjson"

Copilot uses AI. Check for mistakes.
},
"ProficencyLevel": {
"object": "./model/party/profile/proficency-level.mjson"
"ProficiencyLevel": {
"object": "./model/party/profile/proficiency-level.mjson"
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object reference path has been updated to './model/party/profile/proficiency-level.mjson', which correctly points to the renamed .mjson file. However, that .mjson file internally references './proficiency-level.js' which doesn't exist (the file is still named 'proficency-level.js'). This will cause module loading errors when this descriptor is used.

Copilot uses AI. Check for mistakes.
},
"Skill": {
"object": "./model/party/profile/skill.mjson"
Expand Down
2 changes: 1 addition & 1 deletion data/model/job-role-skill-expectation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports.JobRoleSkillExpectation = DataObject.specialize(/** @lends JobRoleSkillE
name: {
value: undefined
},
proficencyScale: {
proficiencyScale: {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

value: undefined
}

Expand Down
12 changes: 6 additions & 6 deletions data/model/job-role-skill-expectation.mjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,17 @@

}
},
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

"ProficencyLevelDescriptor": {
"object": "data/model/party/profile/proficency-level.mjson"
"ProficiencyLevelDescriptor": {
"object": "data/model/party/profile/proficiency-level.mjson"
},
"roleHoldeProficiency": {
"roleHolderProficiency": {
"prototype": "mod/core/meta/property-descriptor",
"values": {
"name": "roleHoldeProficiency",
"name": "roleHolderProficiency",
"valueType": "object",
"cardinality": 1,
"valueDescriptor": {"@": "ProficencyLevelDescriptor"},
"description": "Expections regarding role holder's proficency at that role. That might need to be a range?"
"valueDescriptor": {"@": "ProficiencyLevelDescriptor"},
"description": "Expectations regarding role holder's proficiency at that role. That might need to be a range?"
}
}
}
6 changes: 3 additions & 3 deletions data/model/job-role-skill-importance-level.mjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"prototype": "mod/core/meta/module-object-descriptor",
"values": {
"name": "JobRoleSkillImportanceLevel",
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

"description": "Models proficency levels such as Beginner, Intermediate, Advanced, Expert. Together they belong to a scale",
"description": "Models proficiency levels such as Beginner, Intermediate, Advanced, Expert. Together they belong to a scale",
"propertyDescriptors": [
{"@": "name"},
{"@": "scale"},
Expand Down Expand Up @@ -39,7 +39,7 @@
"isMandatory": true
}
},
"proficencyScaleDescriptor": {
"proficiencyScaleDescriptor": {
"object": "./job-role-skill-importance-level.mjson"
},
"scale": {
Expand All @@ -48,7 +48,7 @@
"name": "scale",
"valueType": "object",
"cardinality": -1,
"valueDescriptor": {"@": "proficencyScaleDescriptor"},
"valueDescriptor": {"@": "proficiencyScaleDescriptor"},
"inversePropertyName": "levels"
}
},
Expand Down
8 changes: 4 additions & 4 deletions data/model/job-role-skill-importance-scale.mjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,17 @@
"isMandatory": true
}
},
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

"proficencyLevelDescriptor": {
"object": "./party/profile/proficency-level.mjson"
"proficiencyLevelDescriptor": {
"object": "./party/profile/proficiency-level.mjson"
},
"levels": {
"prototype": "mod/core/meta/property-descriptor",
"values": {
"name": "levels",
"valueType": "object",
"cardinality": -1,
"valueDescriptor": {"@": "proficencyLevelDescriptor"},
"inversePropertyName": "proficencyScale"
"valueDescriptor": {"@": "proficiencyLevelDescriptor"},
"inversePropertyName": "proficiencyScale"
}
}
}
14 changes: 7 additions & 7 deletions data/model/party/profile/personal-skill-assessment.mjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@": "skill"
},
{
"@": "selfAssessedProficencyLevel"
"@": "selfAssessedProficiencyLevel"
},
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{
"@": "assessmentQuestionnaires"
Expand Down Expand Up @@ -54,7 +54,7 @@
"valueDescriptor": {
"@": "PersonDescriptor"
},
"inversePropertyName": "strengthAssessments"
"inversePropertyName": "skillAssessments"
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchant Probably good

}
},
"SkillDescriptor": {
Expand All @@ -72,17 +72,17 @@
"inversePropertyName": "personalSkillAssessments"
}
},
"ProficencyLevelDescriptor": {
"object": "./proficency-level.mjson"
"ProficiencyLevelDescriptor": {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

"object": "./proficiency-level.mjson"
},
"selfAssessedProficencyLevel": {
"selfAssessedProficiencyLevel": {
"prototype": "mod/core/meta/property-descriptor",
"values": {
"name": "selfAssessedProficencyLevel",
"name": "selfAssessedProficiencyLevel",
"valueType": "object",
"cardinality": 1,
"valueDescriptor": {
"@": "ProficencyLevelDescriptor"
"@": "ProficiencyLevelDescriptor"
},
"isSearchable": true
}
Expand Down
2 changes: 1 addition & 1 deletion data/model/party/profile/personal-strength-assessment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports.PersonalStrengthAssessment = DataObject.specialize(/** @lends PersonalSt
name: {
value: undefined
},
proficencyScale: {
proficiencyScale: {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

value: undefined
}

Expand Down
2 changes: 1 addition & 1 deletion data/model/party/profile/personal-strength.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports.PersonalStrength = DataObject.specialize(/** @lends PersonalStrength.pro
name: {
value: undefined
},
proficencyScale: {
proficiencyScale: {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

value: undefined
}

Expand Down
4 changes: 2 additions & 2 deletions data/model/party/profile/professional-profile.mjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
}
},

"PersonalSkillAssesssmentDescriptor": {
"PersonalSkillAssessmentDescriptor": {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

"object": "./personal-skill-assessment.mjson"
},
"skillAssessments": {
Expand All @@ -100,7 +100,7 @@
"name": "skillAssessments",
"cardinality": -1,
"valueType": "object",
"valueDescriptor": {"@": "PersonalSkillAssesssmentDescriptor"}
"valueDescriptor": {"@": "PersonalSkillAssessmentDescriptor"}
}
},

Expand Down
24 changes: 12 additions & 12 deletions ...odel/party/profile/proficency-level.mjson → ...del/party/profile/proficiency-level.mjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,27 @@
"root": {
"prototype": "mod/core/meta/module-object-descriptor",
"values": {
"name": "ProficencyLevel",
"description": "Models proficency levels such as Beginner, Intermediate, Advanced, Expert. Together they belong to a proficencyScale",
"name": "ProficiencyLevel",
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

"description": "Models proficiency levels such as Beginner, Intermediate, Advanced, Expert. Together they belong to a proficiencyScale",
"propertyDescriptors": [
{"@": "name"},
{"@": "scale"},
{"@": "rank"}
],
"objectDescriptorModule": {
"%": "./proficency-level.mjson"
"%": "./proficiency-level.mjson"
},
"exportName": "ProficencyLevel",
"exportName": "ProficiencyLevel",
"module": {
"%": "./proficency-level"
"%": "./proficiency-level"
},
"object":{"@": "proficency-level"},
"object":{"@": "proficiency-level"},
"parent":{"@": "DataObjectDescriptor"}

}
},
"proficency-level": {
"object": "./proficency-level"
"proficiency-level": {
"object": "./proficiency-level"
},

"DataObjectDescriptor": {
Expand All @@ -39,16 +39,16 @@
"isMandatory": true
}
},
"proficencyScaleDescriptor": {
"object": "./proficency-scale.mjson"
"proficiencyScaleDescriptor": {
"object": "./proficiency-scale.mjson"
},
"scale": {
"prototype": "mod/core/meta/property-descriptor",
"values": {
"name": "scale",
"valueType": "object",
"cardinality": -1,
"valueDescriptor": {"@": "proficencyScaleDescriptor"},
"valueDescriptor": {"@": "proficiencyScaleDescriptor"},
"inversePropertyName": "levels"
}
},
Expand All @@ -59,7 +59,7 @@
"name": "rank",
"valueType": "number",
"isSearchable": true,
"description": "The rank of this proficencyLevel within the scale. Other option for naming: order, level"
"description": "The rank of this proficiencyLevel within the scale. Other option for naming: order, level"
}
}

Expand Down
22 changes: 11 additions & 11 deletions ...odel/party/profile/proficency-scale.mjson → ...del/party/profile/proficiency-scale.mjson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,26 @@
"root": {
"prototype": "mod/core/meta/module-object-descriptor",
"values": {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

"name": "ProficencyScale",
"description": "ProficencyScale group a list of ",
"name": "ProficiencyScale",
"description": "ProficiencyScale groups a list of proficiency levels",
"propertyDescriptors": [
{"@": "name"},
{"@": "levels"}
],
"objectDescriptorModule": {
"%": "./proficency-scale.mjson"
"%": "./proficiency-scale.mjson"
},
"exportName": "ProficencyScale",
"exportName": "ProficiencyScale",
"module": {
"%": "./proficency-scale"
"%": "./proficiency-scale"
},
"object":{"@": "proficency-scale"},
"object":{"@": "proficiency-scale"},
"parent":{"@": "DataObjectDescriptor"}

}
},
"proficency-scale": {
"object": "./proficency-scale"
"proficiency-scale": {
"object": "./proficiency-scale"
},

"DataObjectDescriptor": {
Expand All @@ -38,16 +38,16 @@
"isMandatory": true
}
},
"proficencyLevelDescriptor": {
"object": "./proficency-level.mjson"
"proficiencyLevelDescriptor": {
"object": "./proficiency-level.mjson"
},
"levels": {
"prototype": "mod/core/meta/property-descriptor",
"values": {
"name": "levels",
"valueType": "object",
"cardinality": -1,
"valueDescriptor": {"@": "proficencyLevelDescriptor"},
"valueDescriptor": {"@": "proficiencyLevelDescriptor"},
"inversePropertyName": "scale"
}
}
Expand Down
2 changes: 1 addition & 1 deletion data/model/party/profile/skill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports.Skill = DataObject.specialize(/** @lends Skill.prototype */ {
name: {
value: undefined
},
proficencyScale: {
proficiencyScale: {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

value: undefined
}

Expand Down