Skip to content

Check MJSON files for typos and errors #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
thibaultzanini wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check MJSON files for typos and errors #64

thibaultzanini wants to merge 1 commit into from

Conversation

@thibaultzanini
Copy link
Contributor

@thibaultzanini thibaultzanini commented Jan 8, 2026

  • Fix 'proficency' → 'proficiency' throughout codebase (14+ instances)
  • Fix 'PersonalSkillAssesssmentDescriptor' → 'PersonalSkillAssessmentDescriptor' (triple s)
  • Fix 'roleHoldeProficiency' → 'roleHolderProficiency'
  • Fix 'Expections' → 'Expectations'
  • Fix 'profiule' → 'profile'
  • Fix incomplete description in proficiency-scale.mjson
  • Fix incorrect inverse property in personal-skill-assessment.mjson (strengthAssessments → skillAssessments)
  • Rename proficency-.mjson files to proficiency-.mjson
  • Update all file references to renamed files

@claude
Fix typos and errors in mjson files
d53fe99 
- Fix 'proficency' → 'proficiency' throughout codebase (14+ instances)
- Fix 'PersonalSkillAssesssmentDescriptor' → 'PersonalSkillAssessmentDescriptor' (triple s)
- Fix 'roleHoldeProficiency' → 'roleHolderProficiency'
- Fix 'Expections' → 'Expectations'
- Fix 'profiule' → 'profile'
- Fix incomplete description in proficiency-scale.mjson
- Fix incorrect inverse property in personal-skill-assessment.mjson (strengthAssessments → skillAssessments)
- Rename proficency-*.mjson files to proficiency-*.mjson
- Update all file references to renamed files
Copilot AI reviewed Jan 8, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes numerous spelling errors throughout the codebase, primarily correcting "proficency" to "proficiency" (14+ instances), fixing other typos like "PersonalSkillAssesssmentDescriptor" (triple s) to "PersonalSkillAssessmentDescriptor", "roleHoldeProficiency" to "roleHolderProficiency", and correcting an incorrect inverse property reference. The .mjson descriptor files were also renamed from proficency-.mjson to proficiency-.mjson, and all file references were updated accordingly.

  • Corrects spelling of "proficiency" throughout JavaScript and MJSON files
  • Fixes class and property descriptor names with typos
  • Renames .mjson files and updates internal references
  • Corrects inverse property relationship in personal-skill-assessment.mjson

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
data/model/party/profile/skill.js Renamed property from proficencyScale to proficiencyScale
data/model/party/profile/proficiency-scale.mjson Updated class name, descriptions, file references, and internal object references from proficency to proficiency
data/model/party/profile/proficiency-level.mjson Updated class name, descriptions, file references, and internal object references from proficency to proficiency
data/model/party/profile/professional-profile.mjson Fixed PersonalSkillAssesssmentDescriptor typo (triple s)
data/model/party/profile/personal-strength.js Renamed property from proficencyScale to proficiencyScale
data/model/party/profile/personal-strength-assessment.js Renamed property from proficencyScale to proficiencyScale
data/model/party/profile/personal-skill-assessment.mjson Fixed multiple proficency→proficiency typos and corrected inverse property from strengthAssessments to skillAssessments
data/model/job-role-skill-importance-scale.mjson Updated descriptor references and property names from proficency to proficiency
data/model/job-role-skill-importance-level.mjson Updated descriptor references and descriptions from proficency to proficiency
data/model/job-role-skill-expectation.mjson Fixed roleHoldeProficiency→roleHolderProficiency, updated descriptor references, and corrected Expections→Expectations in description
data/model/job-role-skill-expectation.js Renamed property from proficencyScale to proficiencyScale
data/model.mjson Updated ProficencyScale and ProficencyLevel references to correct spelling
data/instance/party/profile/proficiency-scale.mjson Fixed prototype reference path typo (profiule→profile) and updated scale name reference
Comments suppressed due to low confidence (5)

data/model/party/profile/proficiency-level.mjson:17

  • The module reference has been updated to './proficiency-level', but the actual JavaScript file is still named 'proficency-level.js' (with the typo). This will cause a module loading error. Either the .js file needs to be renamed to 'proficiency-level.js', or this reference should remain as './proficency-level' until the .js file is also renamed.
    data/model/party/profile/proficiency-level.mjson:25
  • The object reference has been updated to './proficiency-level', but the actual JavaScript file is still named 'proficency-level.js' (with the typo). This will cause a module loading error. Either the .js file needs to be renamed to 'proficiency-level.js', or this reference should remain as './proficency-level' until the .js file is also renamed.
    data/instance/party/profile/proficiency-scale.mjson:9
  • The prototype reference has been updated to 'data/model/party/profile/proficiency-scale', but the actual JavaScript file is still named 'proficency-scale.js' (with the typo). This will cause a module loading error. Either the .js file needs to be renamed to 'proficiency-scale.js', or this reference should remain as 'data/model/party/profile/proficency-scale' until the .js file is also renamed.
    data/model/party/profile/proficiency-scale.mjson:16
  • The module reference has been updated to './proficiency-scale', but the actual JavaScript file is still named 'proficency-scale.js' (with the typo). This will cause a module loading error. Either the .js file needs to be renamed to 'proficiency-scale.js', or this reference should remain as './proficency-scale' until the .js file is also renamed.
    data/model/party/profile/proficiency-scale.mjson:24
  • The object reference has been updated to './proficiency-scale', but the actual JavaScript file is still named 'proficency-scale.js' (with the typo). This will cause a module loading error. Either the .js file needs to be renamed to 'proficiency-scale.js', or this reference should remain as './proficency-scale' until the .js file is also renamed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

data/model.mjson
"ProficencyScale": {
"object": "./model/party/profile/proficency-scale.mjson"
"ProficiencyScale": {
"object": "./model/party/profile/proficiency-scale.mjson"
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object reference path has been updated to './model/party/profile/proficiency-scale.mjson', which correctly points to the renamed .mjson file. However, that .mjson file internally references './proficiency-scale.js' which doesn't exist (the file is still named 'proficency-scale.js'). This will cause module loading errors when this descriptor is used.

Suggested change
"object": "./model/party/profile/proficiency-scale.mjson"
"object": "./model/party/profile/proficency-scale.mjson"

Copilot uses AI. Check for mistakes.
data/model.mjson
"ProficencyLevel": {
"object": "./model/party/profile/proficency-level.mjson"
"ProficiencyLevel": {
"object": "./model/party/profile/proficiency-level.mjson"
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object reference path has been updated to './model/party/profile/proficiency-level.mjson', which correctly points to the renamed .mjson file. However, that .mjson file internally references './proficiency-level.js' which doesn't exist (the file is still named 'proficency-level.js'). This will cause module loading errors when this descriptor is used.

Copilot uses AI. Check for mistakes.
@thibaultzanini thibaultzanini self-assigned this Jan 8, 2026
thibaultzanini
thibaultzanini commented Jan 8, 2026
View reviewed changes
data/instance/party/profile/proficiency-scale.mjson
},
"0199f8df-c7b4-7cdc-b68e-78042e80fa30": {
"prototype": "data/model/party/profiule/proficency-scale",
"prototype": "data/model/party/profile/proficiency-scale",
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

data/instance/party/profile/proficiency-scale.mjson
"name": {
"en": {
"US": "Four Level Proficency Scale"
"US": "Four Level Proficiency Scale"
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchant There is a typo Proficency is not a valid English word

data/model/party/profile/personal-skill-assessment.mjson
{
"@": "selfAssessedProficencyLevel"
"@": "selfAssessedProficiencyLevel"
},
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

data/model/party/profile/personal-skill-assessment.mjson
"@": "PersonDescriptor"
},
"inversePropertyName": "strengthAssessments"
"inversePropertyName": "skillAssessments"
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marchant Probably good

data/model/party/profile/personal-strength.js
value: undefined
},
proficencyScale: {
proficiencyScale: {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

data/model/job-role-skill-expectation.js
value: undefined
},
proficencyScale: {
proficiencyScale: {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

data/model/party/profile/skill.js
value: undefined
},
proficencyScale: {
proficiencyScale: {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

data/model/party/profile/proficiency-scale.mjson
{
"root": {
"prototype": "mod/core/meta/module-object-descriptor",
"values": {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

data/model.mjson
},
"ProficencyScale": {
"object": "./model/party/profile/proficency-scale.mjson"
"ProficiencyScale": {
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

data/model/job-role-skill-importance-scale.mjson
"isSearchable": true,
"isMandatory": true
}
},
Copy link
Contributor Author

@thibaultzanini thibaultzanini Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@marchant marchant Awaiting requested review from marchant

Assignees

@thibaultzanini thibaultzanini

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thibaultzanini @claude