[PER-10365] Fix tags not appearing in share sidebar

[aasandei-vsp]

In the edit tags component, the item tags were mapped and filtered to only match tags that were present on the current archive. This seems to be redundant for items that are in the private workspace, because the tags on the item and the tags on the archive have the same type TagVOData.
However, the mapping and filtering would eliminate all tags for the shared items, because none of them would be present in the archive's tags.
In conclusion, eliminating the mapping/filtering would not affect the private workspace and will fix the shared workspace tags.

Issue: PER-10365 Keywords and metadata should show in the sidebar for Share Files section

TEST CASES:
!!! Separate tests for file and folder

1. Create an account or use an existing one (account A)
2. Upload a record/create a folder
3. Add keywords and metadata on record/folder
4. Create a share link for the record/folder with at least editing rights
5. Open a new window
6. Create a new account or log in with a different one(account B)
7. Paste the share link
8. Accept the share and view the record/folder in the shared workspace
9. Click the record/folder
   EXPECTATIONS: The keywords and metadata added should be visible in the sidebar.
10. Add a new keyword and new metadata from the sidebar.
11. Go back to the first window and refresh(account A)
12. Click record/folder that has been shared from this archive
    EXPECTATIONS: The keywords and metadata, including the one added by account B should be visible in the sidebar.

Also search tags might be worth testing!

OBSERVATION: These are the cases I thought of, but please add more if I am missing functionality that should be tested.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.07%. Comparing base (d867a9e) to head (965bba8).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
+ Coverage   47.05%   47.07%   +0.02%     
==========================================
  Files         372      372              
  Lines       11495    11494       -1     
  Branches     1909     1909              
==========================================
+ Hits         5409     5411       +2     
+ Misses       5898     5895       -3     
  Partials      188      188              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cecilia-donnelly]

Thank you for this! This does seem to fix tags appearing in the sidebar, which is great! There is one flow which still won't work with this change, which is removing an existing tag (keyword). The way a member removes a tag is by navigating to it in the dropdown and clicking it to "uncheck" that tag. Since the tags that aren't in the recipient archive still don't appear in the dropdown, that isn't possible to do. This seems to be a big improvement though! I will approve it as at least an interim step.

A bit of context for why we may have been filtering on archive-specific tags, which informed my light testing: originally all tags were global. Here is the design doc explaining the change to archive-specific tags. I was curious to see if this change meant that more tags were visible in search, but it did not, probably because the backend is now doing that archive-specific filtering that used to happen on the front end (when tags were global on the backend). I don't know if that makes sense, but I thought you might be interested in the history!